1. 25 Oct, 2019 1 commit
  2. 05 Sep, 2019 1 commit
  3. 10 Jul, 2019 1 commit
  4. 03 Jun, 2019 1 commit
  5. 01 Nov, 2018 1 commit
    • David Edmundson's avatar
      [ksmserver] Simplify call to kcminit · 8c85bfa6
      David Edmundson authored
      kcminit had a slot to start processing something and a signal to emit
      when it's finished.
      For DBus that's quite bad practice as it can leave you hanging in the
      case of a kcminit crashing. It's better to use the return of the
      original call to signal when something is done.
      From ksmserver we can then just use DBus timeouts set on the interface
      than a secondary timer.
      We also remove a pointless blocking call to kcminit introspecting
      everything, if kcminit is not running it will return with an error
      immediately which is no slower than checking first if it's not running
      and faster if it is.
      Test Plan:
      Logged in
      Session logs showed kcminit ran
      Reviewers: #plasma, broulik
      Reviewed By: #plasma, broulik
      Subscribers: zzag, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D16587
  6. 30 Oct, 2018 3 commits
    • David Edmundson's avatar
      [ksmserver] Add missing license · 50815c0c
      David Edmundson authored
    • David Edmundson's avatar
      [ksmserver] Rewrite Startup · 96a595f1
      David Edmundson authored
      The code is effectively 3 startup phases each of which has some parallel
      methods that need to be complete before moving onto the next phase.
      The old code had a tonne of methods all of which tracking what state
      we're in and trying to start the next method in the chain handling
      things out of order.
      This simplifies everything into 3 composite kjobs. A lot more classes,
      but each one tiny with the flow more readable.
      Code should be effectively the same. The startup sound is moved ever so
      slightly earlier to be when phase 2 starts rather than just after
      kcminit2 finishes (midway through the old phase 2), but no significant
      behavioural changes here.
      Test Plan: Logged in with session restore and without
      Reviewers: #plasma, apol
      Reviewed By: apol
      Subscribers: apol, broulik, anthonyfieroni, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D16231
    • David Edmundson's avatar
      [ksmserver] Split startup into separate class · 248dadf4
      David Edmundson authored
      Everything related to Plasma startup goes in Startup everything relating
      to X session management stays in KSMServer.  Restoring the window
      manager currently stays inside ksmserver as it passes the session ID as
      an argument and at various points checks if something the client is the
      Relevant methods move to server.cpp to keep one class per cpp file.
      KSMServer gains some signals as it can no longer call the startup methods
      directly to continue the process.
      This is part of a cleanup series in ksmserver. (The friend class will disappear
      in the next commit)
      Behaviour should remain identical.
      Test Plan: Logged in on X
      Reviewers: #plasma, graesslin
      Reviewed By: #plasma, graesslin
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D16225