Summary:
Warnings such as:
```
CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:37 (me
ssage):
  The KF5:: namespace for KSysGuard targets is deprecated.  Please use
   KSysGuard as namespace.
 Call Stack (most recent call first):
   /usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package)
   CMakeLists.txt:55 (find_package)
```

Test Plan: cmake does not output those warnings

Reviewers: #plasma, ahiemstra, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29623

Summary:
as we can't kill completely kcmshell just yet, hack intothe services runner to
replace on the fly the exec line of the service to systemsettings

BUG: 402790
FIXED-IN: 5.19.0

Test Plan:
search and launch directly for a module, systemsettings is launched wit hthe
proper module loaded

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: broulik, ngraham, davidre, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29157

Fix in the f2e34dbb got partially reverted by introduction
of AbstractNotificationsModel in 2357e6f2.

Summary: This allows one to subscribe to notifications from notification server.

Test Plan:
tested using very simple QML

```
import QtQuick 2.0
import org.kde.notificationmanager 1.1 as Notifications

...
Notifications.NotificationWatchedModel {
    id: model
}

```

Reviewers: #plasma, broulik, davidedmundson

Reviewed By: #plasma, broulik

Subscribers: nicolasfella, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28509

Summary:
The config keys/sorting enum have been moved to a new file, before this the runner included the header of the config class.
This patch originated from https://phabricator.kde.org/D27513, but it was requested to split it up into separate patches.

Test Plan: Should compile.

Reviewers: davidedmundson, ngraham, broulik, meven, apol

Reviewed By: meven

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27576

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Last bits needed for T12778.

CCBUG: 420934

Test Plan: {F8295118}

Reviewers: bugseforuns, #plasma, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T12778

Differential Revision: https://phabricator.kde.org/D29516

Summary:
Expander arrow should hide when all icons are visible and no icon is hidden. When dialog with hidden items is hidden ListView does not update its count property - property is update on redraw. As a result expander arrow is still visible/hidden until user clicks on any plasmoid to show dialog.

BUG: 420924

Test Plan:
* select/deselect "Show all items" in settings, save, expander arrow should hide/show imidiatelly
* select almost all items to "Always shown", leave "Keyboard indicator" as "Shown when relevant". Press Casp Lock, expander arrow should hide/show correctly

Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson

Reviewed By: #plasma_workspaces, #plasma, broulik, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28180

Summary:
I probably introduced the issue fixed here with D29315, sorry. This patch makes the
parent layout invisible when all of its children are invisible, so it doesn't keep
taking up some vertical space after a previously-visible inhibition goes away.

Test Plan: When an inhibition goes away, it once again looks like it should: {F8288112}

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29467

Summary: The negative top margin was not necessary and causes missing round corners.

Test Plan:
No visual change on master
With D29479, rounded corners should appear again

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29490

Summary: This hides the plasmoidHeading on history for not grouped notifications

Test Plan:
After:
{F8288756}

Reviewers: broulik, ngraham

Reviewed By: broulik, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Maniphest Tasks: T10470

Differential Revision: https://phabricator.kde.org/D29474

Summary: Depends on D29449

Test Plan:
{F8288340}

{F8288339}

Reviewers: #plasma, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29468

Summary:
This fixes:
- Indented notifications line (it's back)
- Heading being non-clickable
- Buttons not being right-aligned in history
- Keyboard navigation
- Long app names

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29234

When setting "until turned off" it effectively sets it to today in a year. Now with leap year this appears to have broken.
Instead, just use 100 days, which is plenty, even if we come up with a "for 1 month" option maybe.

Differential Revision: https://phabricator.kde.org/D28740

Summary:
In some rare situations SNI icons are not rendered. It happens randomly, only some users are affected. It does not happen on every login.
Only SNI icons are not rendered, Plasmoids are fine. Restarting plasmashell or re-adding systemtray applet helps.

In QML all roles need to be defined before model is used. When data engines is used a a source for a data model, all roles has to be defined and proper value assigned (not a null QVariant). StatusNotifierItemSource does this properly, but in some situations it sets null QVariant for Icon. Setting empty/null QVariant removes key/role from the date set (DataConteiner implementation). If data model was loaded earlier or later when Icon has proper value it will work properly. In some rare situation it is possible that data model is loaded when Icon has null value assigned (in other words - removed), role is removed from the data model and not avaiable to system tray applet.

This fix makes sure that there is always a value for Icon role. To check if icon is null native method has to be used - QML does not understand that QIcon can be null.

BUG: 419305
FIXED-IN: 5.18.5

Test Plan: I don't have any reliable method to reproduce this issue.

Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29386

Summary:
This makes it take up less vertical space in the header area and also match the similar
message in the notifications applet.

Test Plan: {F8274308}

Reviewers: #vdg, #plasma, broulik, manueljlin, mart

Reviewed By: #vdg, #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T10470

Differential Revision: https://phabricator.kde.org/D29315

Summary:
This allows us to use the new consistent appearance introduced with D29074.

Depends on D29074

Test Plan: {F8273822}

Reviewers: #plasma, #kirigami

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29075

Rather than using a KDirWatch that points to the wrong place.

Differential Revision: https://phabricator.kde.org/D29411

Summary:
After adding a new plasmoid (applet), for example a new Media Player, several empty icons are rendered in the system tray which hides existing icons.
The bug occurs after opening Gwenview while the Media Player applet is NOT in use.
The systray icons reappear when Gwenview is closed or another source starts playing.

BUG: 418662

Test Plan: Start Gwenview when Media Player is not in use. All icons should render correctly.

Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, apol, davidedmundson, mart

Reviewed By: #plasma_workspaces, #plasma, mart

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29344

Summary:
There was a slight issue introduced with D28109: the systray highlight can now cover up the icons it's highlighting.

This isn't really an issue with Breeze because it uses a line for a highlight, but it is for themes that use a filled-style highlight.

I set a z value for the highlight that should ensure it's now drawn only behind the icon.

Test Plan:
Tested with the //Mondrian// Plasma theme

Before:
{F8280717}

After:
{F8280718}

Reviewers: kmaterka, #plasma

Reviewed By: kmaterka

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29380

Summary: Some `onXyzChanged` signals do not send value - fix connection to use value directly from the sender.

Test Plan: Disable or enable plasmoid in System Tray setting - it should work correctly.

Reviewers: #plasma_workspaces, #plasma, ngraham, apol, broulik, davidedmundson

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29356

Apparently by default it only considers "out of range" indices invalid but an invalid one as valid.

CCBUG: 418347

Differential Revision: https://phabricator.kde.org/D29297

Summary:
Because the actions are always the same the X-Plasma-Request-Actions-Once property can be set to true.
Depends on D29175.

Test Plan: Still displays action.

Reviewers: #plasma, meven, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29320

Test Plan: Using it

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29150

Test Plan:
Before: {F8273701}
After: {F8273853}

Reviewers: #vdg, broulik, ngraham

Reviewed By: #vdg, broulik, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29301

Summary:
As requested in D28196 this patch removes the caching feature.
This caching causes issues when the user has multiple profiles, because the cached value
is not updated as long as the database exists.

Depends on D28473.

Test Plan: Should compile, no changes to lookup logic made.

Reviewers: #plasma, bruns, broulik

Reviewed By: bruns

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28619

Summary:
As requested in D28196 this patch handles the early return and the formatting.
Additionally QRegularExpression has been used instead of QRegExp and QStringLiteral instead of QString.

Test Plan:
Should compile and work exactly as before.

To test migration to QRegularExpression:
create multiple profiles
delete the `dbfile` entry from the general group in .config/kdeglobals
restart krunner and make sure that the value of the dbfile entry is the path to the default profile.
The bookmarks should also be displayed.

Reviewers: bruns, broulik, #plasma

Reviewed By: bruns

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28473

Rather than calling into KLauncher directly.
I think silently failing rather than using a modal potentially interrupting startup is acceptable here?

Differential Revision: https://phabricator.kde.org/D29226

Francis Thérien authored Apr 28, 2020 and Nate Graham committed Apr 28, 2020

Summary:
Sort environment scripts before they are sourced. User scripts should run after system scripts to ensure that user preferences take precendence over system defaults. Scripts in each location (user and system) are then separately sorted in lexical order to ensure deterministic source order.

BUG: 420085
FIXED-IN: 5.19.0

Reviewers: #plasma, davidedmundson, apol

Reviewed By: apol

Subscribers: cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28941

Acked-by: d_ed

Summary: Depends on D29055 and D29054

Reviewers: broulik, davidedmundson, zzag, meven

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29056

Fixes notifications of different origins being grouped together when they shouldn't.

Differential Revision: https://phabricator.kde.org/D29214

Summary: This adds a footer element that will replace with a possible footer that the contained plasmoid could have, given that they are using a Page.

Test Plan: {F8258401}

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T10470

Differential Revision: https://phabricator.kde.org/D29142

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"