1. 25 Jun, 2020 2 commits
  2. 24 Jun, 2020 1 commit
  3. 17 Jun, 2020 1 commit
  4. 08 Jun, 2020 1 commit
    • Nate Graham's avatar
      [Lock screen] Make clearPassword() do what it says and then use it · b3030730
      Nate Graham authored
      Right now the clearPassword() signal does not actually clear the
      password; it only selects all text. This is a violation of its name
      as well as being pointless since there's no longer a way to see the
      unmasked text, which means you always need to re-enter the whole
      password anyway.
      
      BUG: 412252
      FIXED-IN: 5.20
      b3030730
  5. 04 Jun, 2020 1 commit
  6. 31 May, 2020 1 commit
    • Eugene Popov's avatar
      Don't hide clock after idle time on login screen · 53162d2a
      Eugene Popov authored
      Currently on the login screen after some idle time (60 seconds) all controls become hidden, including clock. This commit makes the clock remain visible after idle time (similar to the lock screen).
      53162d2a
  7. 29 May, 2020 1 commit
    • Nate Graham's avatar
      Show percentage in OSD when a progress bar is visible · a4b6a9da
      Nate Graham authored
      The new design makes this visually simple, and in fact I think it
      improves the composition to have the progrss bar anchored by dark-colored
      elements on both sides.
      
      OSDs without progress bars are unaffected.
      
      BUG: 385602
      FIXED-IN: 5.20
      
      Merge Request: !15
      a4b6a9da
  8. 22 May, 2020 1 commit
  9. 20 May, 2020 1 commit
    • Kai Uwe Broulik's avatar
      [OSD] Fix ProgressBar potentially growing the dialog · c067d498
      Kai Uwe Broulik authored
      Depending on font size and settings the ProgressBar's implicit size might be wider
      than our minimum size of 15 gridUnit. This causes the Popup to change size when switching
      from ProgressBar (e.g. changing volume) to Text (e.g. volume muted).
      
      By setting preferredWidth to 1 we ensure we never exceed the overall minimum size
      when the ProgressBar is shown.
      c067d498
  10. 19 May, 2020 2 commits
    • Nate Graham's avatar
      [lookandfeel] Port OSD's slider to PlasmaComponents3 · b9aba6eb
      Nate Graham authored
      It has more correct vertical sizing, which now matters with the new
      OSD design.
      b9aba6eb
    • Kai Uwe Broulik's avatar
      Use more compact OSD · af31ad46
      Kai Uwe Broulik authored
      Summary:
      A frequent complaint over the years is the size of the OSD. It was tried to alleviate that by having it start fading out slowly immediately but the way it was done wasn't ideal, didn't work on Wayland, and also causes flickering issues in recent Qt versions.
      This changes the OSD to a bar-like design similar to the one used in Plasma 4.
      
      BUG: 344393
      BUG: 372665
      FIXED-IN: 5.20.0
      
      Depends on D29263
      
      Test Plan:
      Various OSD messages
      {F6773939}
      It can grow, if necccessary, to accomodate translations, up to half the screen width.
      With Air theme
      {F6773940}
      Full desktop screenshot for some context
      {F6773941}
      
      Reviewers: #plasma, #vdg, broulik, niccolove, ndavis
      
      Reviewed By: #vdg, niccolove, ndavis
      
      Subscribers: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codezela, filipf, zzag, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D20569
      af31ad46
  11. 06 May, 2020 1 commit
  12. 05 Apr, 2020 1 commit
    • Nate Graham's avatar
      Stop multiplying duration values · 29587025
      Nate Graham authored
      Summary:
      After D28144, some animations are now too long because they were inappropriately
      multiplying a duration value. That's no longer necessary, so let's remove the
      multiplication.
      
      Depends on D28144
      
      Test Plan: Various things that were a bit too slow before feel just right now
      
      Reviewers: #vdg, #plasma, cblack
      
      Reviewed By: #vdg, #plasma, cblack
      
      Subscribers: cblack, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28238
      29587025
  13. 18 Feb, 2020 1 commit
  14. 10 Feb, 2020 1 commit
  15. 29 Jan, 2020 2 commits
    • Marco Martin's avatar
      search for a default wallpaper in lookandfeel · ecea557f
      Marco Martin authored
      Summary:
      now look and feel packages can specify a default image wallpaper.
      when a new containment is created at first plasma start or at activity creation
      search for a default wallpaper inthe order:
      look and feel package
      if fails, from the plasma theme
      
      we are sure to find a default after it as if neither of those specify one,
      the wallpaper specified by the breeze plasma theme (Next) will be used
      
      D21225 takes care of setting the wallpaper when a lnf theme is selected by the kcm
      
      Test Plan:
      tested to start plasma with an empty config file with different themes
      that do or don't include wallpapers
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: kossebau, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21226
      ecea557f
    • Marco Martin's avatar
      search for a default wallpaper in lookandfeel · 670f3ec5
      Marco Martin authored
      Summary:
      now look and feel packages can specify a default image wallpaper.
      when a new containment is created at first plasma start or at activity creation
      search for a default wallpaper inthe order:
      look and feel package
      if fails, from the plasma theme
      
      we are sure to find a default after it as if neither of those specify one,
      the wallpaper specified by the breeze plasma theme (Next) will be used
      
      D21225 takes care of setting the wallpaper when a lnf theme is selected by the kcm
      
      Test Plan:
      tested to start plasma with an empty config file with different themes
      that do or don't include wallpapers
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: kossebau, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21226
      670f3ec5
  16. 20 Dec, 2019 1 commit
  17. 13 Dec, 2019 2 commits
  18. 07 Dec, 2019 2 commits
  19. 03 Dec, 2019 1 commit
    • David Edmundson's avatar
      [sddm-theme] Fix initial focus after SDDM QQC2 Port · e7803ecc
      David Edmundson authored
      Summary:
      QQC2 StackView has a major behavioural difference
      
      QQuickStackViewPrivate::setCurrentItem
              item->setFocus(true);
      
      This as a general rule makes sense, especially if you're pushing a whole
      focus scope onto the stackView, it would automatically select the right
      element. However as our base was not a focus scope the
      SessionManagementScreen instance itself got focus, taking it away from
      the child password box.
      
      LockScreenUi has to be changed so that it sets the initial focus the
      same even though the stackview is on QQC1.
      
      Test Plan:
      qmlscene in the sddm-theme directory with the dummydata setup
      locked the screen regularly
      
      Lots of gammaray
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: davidre, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25261
      e7803ecc
  20. 25 Nov, 2019 1 commit
  21. 23 Nov, 2019 1 commit
    • Méven Car's avatar
      [lockscreen] Clear password field when system suspends · a4e18e2b
      Méven Car authored
      Summary:
      BUG: 414399
      FIXED-IN: 5.18
      
      Test Plan:
      1. Lock screen
      2. type something in the password field
      3. Close lid/suspend system
      4. Reopen Lid
      
      Before:
      Password text is kept as in step 2
      
      After:
      Password text is empty
      
      Reviewers: #plasma, broulik, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25487
      a4e18e2b
  22. 19 Nov, 2019 1 commit
    • Filip Fila's avatar
      Use the same avatar size in lock, login and logout screens · f56e800c
      Filip Fila authored
      Summary:
      Currently the avatar in the logout screen is noticeably smaller than the avatar in the lock and logout screens.
      
      This patch roughly bases the size value on what is produced in the lock and logout, and then applies it to the logout screen.
      
      Test Plan:
      Before (logout screen):
      {F7680624}
      
      After (logout screen):
      {F7680632}
      
      Before (lock screen):
      {F7680634}
      
      After (lock screen):
      {F7680635}
      
      Reviewers: #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: davidedmundson, ngraham, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T11093
      
      Differential Revision: https://phabricator.kde.org/D25024
      f56e800c
  23. 12 Nov, 2019 1 commit
    • David Edmundson's avatar
      [sddm-theme] Fix initial focus after SDDM QQC2 Port · 2d066f00
      David Edmundson authored
      Summary:
      QQC2 StackView has a major behavioural difference
      
      QQuickStackViewPrivate::setCurrentItem
              item->setFocus(true);
      
      This as a general rule makes sense, especially if you're pushing a whole
      focus scope onto the stackView, it would automatically select the right
      element. However as our base was not a focus scope the
      SessionManagementScreen instance itself got focus, taking it away from
      the child password box.
      
      LockScreenUi has to be changed so that it sets the initial focus the
      same even though the stackview is on QQC1.
      
      Test Plan:
      qmlscene in the sddm-theme directory with the dummydata setup
      locked the screen regularly
      
      Lots of gammaray
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: davidre, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25261
      2d066f00
  24. 11 Nov, 2019 1 commit
    • David Edmundson's avatar
      Fix binding loop in lockscreen media controls · 419b9708
      David Edmundson authored
      Summary:
      When we load and position the Image the height is constrained, the width
      is not. The image fillMode is set as  PreserveAspectFit so the width
      will adjust to fit the aspect ratio,
      
      Therefore we only want to set a fixed height on the sourceSize, it will
      automatically match the resultant width.
      
      BUG: 413087
      FIXED-IN: 5.17.3
      
      Test Plan:
      I was unable to reproduce the state.
      Patch is based on reading the code and docs
      
      Reviewers: #plasma, broulik, ngraham
      
      Reviewed By: #plasma, broulik, ngraham
      
      Subscribers: broulik, filipf, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25252
      419b9708
  25. 07 Nov, 2019 1 commit
  26. 29 Oct, 2019 1 commit
  27. 11 Oct, 2019 1 commit
  28. 23 Sep, 2019 1 commit
    • Kishore Gopalakrishnan's avatar
      Remove some spacing on lockscreen that was causing elements to get cut off on small displays · cb96abf9
      Kishore Gopalakrishnan authored
      Summary:
      This patch removes some spacing which was making the 'switch users' button get slightly cut off on small displays (1366x768). Quite a few old laptops have screens of this size, so it is good to take into account that display size as well, as long as it doesn't negatively affect the appearance for large displays.
      
      BUG: 410801
      FIXED-IN: 5.17.0
      
      Test Plan:
      Lock screen when connected to a low-res display and check that the 'switch users' button isn't cut off.
      
      **Before this patch:**
      Lockscreen on small display (1366x768): {F7330101}
      Lockscreen on big display (1920x1080): {F7330096}
      
      **After this patch:**
      Lockscreen on small display (1366x768): {F7342190}
      Lockscreen on big display (1920x1080): {F7342191}
      
      Reviewers: #plasma, #vdg, ngraham, filipf
      
      Reviewed By: #vdg, ngraham, filipf
      
      Subscribers: filipf, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23786
      cb96abf9
  29. 17 Sep, 2019 1 commit
    • Nate Graham's avatar
      When asked to switch sessions, jump to session creation if there's nothing to switch to · c87d9064
      Nate Graham authored
      Summary:
      TL;DR version: whenever you currently would be taken to a session switcher page where the only possible action is to go to SDDM and start a new session, instead just show SDDM immediately instead.
      
      Currently, the session switcher screen suffers from a few UX problems:
      - There's a fake "start new session" item that looks like a button but isn't clickable
      - Asking to switch users always goes to the screen where you can switch to existing sessions even if there are no existing sessions to switch to, which is an unnecessary extra step
      
      This patch aims to solve those problems in the following ways:
      - Don't show a fake "start new session" item in the Breeze theme; instead add a real button in the UI to do this
      - When asked to show the session management screen and there is only one session so the on;y thing you could do on that screen is create another session, instead just go to session creation directly
      - For themes where the fake "start new session" button is shown, use a better icon that doesn't make it look like a clickable button
      
      BUG: 386361
      FIXED-IN: 5.17.0
      
      Depends on D23279
      
      Test Plan:
      1. Have only one session > Kickoff/Kicker/dash/Krunner > Switch User -> you go directly to SDDM where you can start a new session
      2. Start a new session, then Switch user again -> you go to the session management screen where you can switch to the other session, or start a new one
      
      Videos:
      Clicking "Switch User" when there are no other sessions: {F7264475}
      
      Clicking "Switch User" when there is another session to switch to, and then switching to it: {F7264476}
      
      Clicking "Switch User" when there is another session to switch to, and then starting a new session: {F7264480}
      
      Switching between multiple sessions in the session switcher: {F7264483}
      
      If the fake "New Session" item is shown (e.g in other themes), here's what it now looks like: {F7264485}
      
      Reviewers: #plasma, #vdg, GB_2, mart
      
      Reviewed By: #plasma, #vdg, GB_2, mart
      
      Subscribers: GB_2, gregormi, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23283
      c87d9064
  30. 28 Aug, 2019 1 commit
  31. 26 Aug, 2019 2 commits
  32. 21 Aug, 2019 1 commit
    • Nate Graham's avatar
      [Lock screen] Always show "Switch User" button regardless of whether fake... · de409edb
      Nate Graham authored
      [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown
      
      Summary:
      Because the fake {nav Switch User} item in the switcher UI counts as a session, the button
      was always being shown. But if and when that changes and the fake item is no longer shown,
      the {nav Switch User} button itself will stops being shown potentially locking out
      non-logged-in users in multi-user computers where the only logged-in user has locked the
      screen.
      
      This patch drops the conditional check entirely and always shows the {nav Switch User}
      button when session creation/switching is possible.
      
      Test Plan: No change; {nav Switch User} button is still shown.
      
      Reviewers: mart, #plasma, #vdg, filipf
      
      Reviewed By: #vdg, filipf
      
      Subscribers: filipf, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23279
      de409edb
  33. 10 Aug, 2019 1 commit
  34. 05 Aug, 2019 1 commit