- 18 May, 2020 1 commit
-
-
Kai Uwe Broulik authored
Notification spec says, when replacing a notification: > The server must atomically (ie with no flicker or other visual cues) replace the given notification with this one. Notifications shifting about is a "visual cue". Differential Revision: https://phabricator.kde.org/D29771
-
- 15 May, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 13 May, 2020 1 commit
-
-
Filip Fila authored
Summary: Even when the vendor logo is turned off it can be briefly seen when the login screen changes from the fadeout state back into normal. Comments in other code say that "OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)" so this patch replaces it with NumberAnimation. There's also a minor fix included - placing the drop shadow sooner in the hierarchy because it should be drawn underneath an object, not in front of it. Test Plan: Reduce the fadeout time to something small and then: `sddm-greeter --test-mode --theme /usr/share/sddm/themes/breeze` Reviewers: ngraham, cblack, #plasma, mart Reviewed By: ngraham, #plasma, mart Subscribers: mart, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D29351
-
- 10 May, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 06 May, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 05 May, 2020 2 commits
-
-
Jonathan Esk-Riddell authored
GIT_SILENT
-
Kai Uwe Broulik authored
When setting "until turned off" it effectively sets it to today in a year. Now with leap year this appears to have broken. Instead, just use 100 days, which is plenty, even if we come up with a "for 1 month" option maybe. Differential Revision: https://phabricator.kde.org/D28740
-
- 04 May, 2020 2 commits
-
-
Konrad Materka authored
Summary: In some rare situations SNI icons are not rendered. It happens randomly, only some users are affected. It does not happen on every login. Only SNI icons are not rendered, Plasmoids are fine. Restarting plasmashell or re-adding systemtray applet helps. In QML all roles need to be defined before model is used. When data engines is used a a source for a data model, all roles has to be defined and proper value assigned (not a null QVariant). StatusNotifierItemSource does this properly, but in some situations it sets null QVariant for Icon. Setting empty/null QVariant removes key/role from the date set (DataConteiner implementation). If data model was loaded earlier or later when Icon has proper value it will work properly. In some rare situation it is possible that data model is loaded when Icon has null value assigned (in other words - removed), role is removed from the data model and not avaiable to system tray applet. This fix makes sure that there is always a value for Icon role. To check if icon is null native method has to be used - QML does not understand that QIcon can be null. BUG: 419305 FIXED-IN: 5.18.5 Test Plan: I don't have any reliable method to reproduce this issue. Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Reviewed By: ngraham Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D29386
-
Kai Uwe Broulik authored
Rather than using a KDirWatch that points to the wrong place. Differential Revision: https://phabricator.kde.org/D29411
-
- 01 May, 2020 1 commit
-
-
Kai Uwe Broulik authored
Apparently by default it only considers "out of range" indices invalid but an invalid one as valid. CCBUG: 418347 Differential Revision: https://phabricator.kde.org/D29297
-
- 27 Apr, 2020 1 commit
-
-
Kai Uwe Broulik authored
Fixes notifications of different origins being grouped together when they shouldn't. Differential Revision: https://phabricator.kde.org/D29214
-
- 25 Apr, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 22 Apr, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 19 Apr, 2020 3 commits
-
-
David Faure authored
-
David Faure authored
-
David Faure authored
(seen during plasma-bigscreen startup) (cherry picked from commit 13616ee1)
-
- 17 Apr, 2020 1 commit
-
-
Kai Uwe Broulik authored
Noticed this while refactoring something in the area. Differential Revision: https://phabricator.kde.org/D28905
-
- 14 Apr, 2020 1 commit
-
-
Kai Uwe Broulik authored
This mutates the source array. In practice actions don't really change in existing notifications but still better to not do that. Differential Revision: https://phabricator.kde.org/D28650
-
- 06 Apr, 2020 2 commits
-
-
Marco Martin authored
Summary: launchersOrder and the actual url data can be different: in case of preferred:/ urls launcherorder will have that for (for serialization) and the actual appdata url will be decoded as for instance Applications:firefox.desktop. this url is the one that needs to be compared to know the actual launcher order BUG:418483 Test Plan: firefox stays in first position when pinned as preferred://browser Reviewers: #plasma, ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D28632
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 05 Apr, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 31 Mar, 2020 2 commits
-
-
Jonathan Esk-Riddell authored
GIT_SILENT
-
Kai Uwe Broulik authored
GHNS Quick Button signals changedEntriesChanged initially even if nothing changed. While this is a bug that should be fixed in GHNS, the wallpaper model didn't handle the case well, when the model was reloaded while a preview was being generated. It looks up whether a preview exists by QUrl and stores a QPersistentModelIndex. However, when the model is reloaded and it accesses data for the same QUrl, the job might still be in-flight, but the QPersistentModelIndex is invalid as the model has been reset. This fixes it by performing all lookups exclusively on QPersistentModelIndex. The hash lookup is optimized for data() (loads of accesses) with the slower key() lookup being done only when the less frequently occurring thumbnail generation finishes/fails. It will now do two preview jobs initially, but at least it shows something again... BUG: 419234 FIXED-IN: 5.18.4 Differential Revision: https://phabricator.kde.org/D28420
-
- 30 Mar, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 29 Mar, 2020 1 commit
-
-
David Edmundson authored
Summary: It's possible to have a .desktop file in your recent documents list as you were editing it. Either as a .desktop file or masquerading as something else. By default we would process the .desktop file like a .desktop file. You do get a prompt if the .desktop file is not executable like in dolphin. Given we know from context that we're showing recent "Documents" we may as well turn that behaviour off without risk of ill effects. BUG: 419310 Test Plan: Created .desktop file (masquerading as something else) Had it in my recent documents after opening in another format Loaded the file from krunner. It now opened in my text editor instead of running the Exec line Reviewers: #plasma, ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D28369
-
- 28 Mar, 2020 1 commit
-
-
Nate Graham authored
Plasma 5.18 depends on Qt 5.12, but configTimeZones.qml was unnecessarily requiring 5.13 by importing QtQuick 2.13.
-
- 26 Mar, 2020 1 commit
-
-
Nicolas Fella authored
Summary: Else the entry is still in cfg_shownItems/cfg_hiddenItems and the config UI will display it as shown instead of disabled. BUG: 419197 Reviewers: #plasma, kmaterka, broulik Reviewed By: #plasma, broulik Subscribers: broulik, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D28311
-
- 24 Mar, 2020 2 commits
-
-
Nate Graham authored
Summary: This patch fixes several errors in the code: - The property is named `font.minimumPixelSize`, not `minimumPixelSize` - The calculation in `minimumPixelSize` did not make sense - Setting the height to `dateLabel.paintedHeight` is nonsensical BUG: 417852 FIXED-IN: 5.18.4 Test Plan: {F8186873} Reviewers: #vdg, #plasma, cblack, davidedmundson Reviewed By: #vdg, #plasma, cblack, davidedmundson Subscribers: davidedmundson, cblack, muesli, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D28172
-
Kai Uwe Broulik authored
Rather than relying on KWin to have reconfigured, which isn't the case when merely changing the number of rows. BUG: 408783 FIXED-IN: 5.18.4 Differential Revision: https://phabricator.kde.org/D28216
-
- 21 Mar, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 17 Mar, 2020 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 13 Mar, 2020 1 commit
-
-
Allan Sandfeld Jensen authored
Summary: The property currentValue is conflicting making the qml file not run. Reviewers: #plasma_workspaces, davidedmundson Reviewed By: #plasma_workspaces, davidedmundson Subscribers: kmaterka, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D26923
-
- 10 Mar, 2020 1 commit
-
-
Jonathan Esk-Riddell authored
GIT_SILENT
-
- 09 Mar, 2020 4 commits
-
-
Kai Uwe Broulik authored
Instead of comparing the state of the action to the action name, compare it to the argument the action will invoke it with. In contrast to checkboxes, which are independent actions with a boolean state, radio menu items all refer to the same action (e.g. "Zoom") and then pass the new state ("zoom-100", "zoom-200", etc) as target when invoking the action. CCBUG: 418385 Differential Revision: https://phabricator.kde.org/D27885
-
Kai Uwe Broulik authored
According to documentation [1] a menu item has a target attribute, which is "the parameter to pass when activating the action". Furthermore, the action "Activate" method specifies "If the action activation requires a parameter then this parameter must be given in the second parameter (av).". Also implements a TODO in the code. [1] https://wiki.gnome.org/Projects/GLib/GApplication/DBusAPI CCBUG: 418385 Differential Revision: https://phabricator.kde.org/D27884
-
Kai Uwe Broulik authored
It just adds noise. Differential Revision: https://phabricator.kde.org/D27879
-
Kai Uwe Broulik authored
HelperMatch type was used to identify them in run but this also causes them to score way higher than anything else (except ExactMatch). CCBUG: 418529 Differential Revision: https://phabricator.kde.org/D27886
-
- 06 Mar, 2020 1 commit
-
-
Summary: Otherwise, setLayout function might be called for already destructed instance of ItemContainer, leading to double reference counter decrement of m_layout QPointer, eventually invalidating such pointers prematurely. BUG: 417603 Test Plan: 1) Unlock widgets via command: qdbus org.kde.plasmashell /PlasmaShell evaluateScript "lockCorona(false)" 2) On desktop push right mouse button and select menu item 'Add Widgets...' 3) Add various widgets to desktop using drag'n'drop on desktop. I've added at least following widgets on same desktop screen: Audio Volume, Battery and Brightness, Binary Clock, Clipboard, Color Picker, Grouping Plasmoid, Quick Chat 4) Remove just added widgets in random order 5) If necessary, repeat steps 3 and 4 a few times If widgets aren't appearing on desktop despite adding them via drag'n'drop, it's bugged and ready to crash. But it's not a requirement for crash. 6) lock widgets via command: qdbus org.kde.plasmashell /PlasmaShell evaluateScript "lockCorona(true)" 7) repeat steps 1-6 multiple times 8) plasmashell shouldn't crash Reviewers: ngraham, davidedmundson, mart Reviewed By: davidedmundson Subscribers: cfeck, anthonyfieroni, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D27650
-
- 25 Feb, 2020 1 commit
-
-
Jonathan Esk-Riddell authored
GIT_SILENT
-
- 24 Feb, 2020 1 commit
-
-
Nate Graham authored
Summary: CCBUG: 412114 Test Plan: {F8116018} (The icon size is too large by default but that's not a bug in this patch) Reviewers: #plasma, davidedmundson, meven, ndavis Reviewed By: meven, ndavis Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D27530
-