There's 4 unit (Items got added) now. Unlikely a job has all of them, however.

Fushan Wen authored May 31, 2022 and Nate Graham committed Jun 02, 2022

FEATURE: 403384
FIXED-IN: 5.26

ivan tkachenko authored Jun 01, 2022 and Nate Graham committed Jun 02, 2022

BUG: 434972

This reverts commit e26425e5.

The KCM does not always include the install folder in the search paths.

As discussed in !1233, a revert is
the best option for the time being.

BUG: 453765

Fushan Wen authored Jun 02, 2022 and Nate Graham committed Jun 02, 2022

In panelview.cpp, the old window focus is restored when switching to
Passive status. This fixes the behavior by setting the panel status to a
status that is not AcceptingInputStatus.

BUG: 454729
CCBUG: 352476
FIXED-IN: 5.25

This is a common snippet of code in applets. It prevents applet from
re-expanding again when user clicks on the compact representation when
the applet is already expanded and located on a desktop containment.

This is a common snippet of code in applets. It prevents applet from
re-expanding again when user clicks on the compact representation when
the applet is already expanded and located on a desktop containment.

This will be used to show all sections in "All Applications".

Otherwise the user needs to manually tab over to the Unlock button
first, which is annoying. And they may not even think to do it at all.

The `forceActiveFocus()` is because the stack view does not manually pass focus
to the item you push onto it; this needs to be handled manually.

BUG: 454707

This makes the current image focused again by default.

The delimiter might change if the settings are changed.
By having a member variable, we still avoid re-creating the same regex for every time the runner is queried.

BUG: 454596

A new image is added to the default folder.

CCBUG: 454692

The hash sign # will be converted to % when using string argument type.

CCBUG: 454692

`wallpaper.configuration.Image` has string type, and assigning a string
value from QML to a url in C++ will truncate the string at the hash char.
This changes `image` data type to string to fix the bug.

BUG: 454692
FIXED-IN: 5.26

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

When running this:

    ~/kde/usr/lib/libexec/kscreenlocker_greet --testing --theme ~/kde/src/plasma-workspace/lookandfeel

it used to generate error like this:

    /usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/UserList.qml:61:9: Unable to assign [undefined] to bool

Because not every users list model provides all the properties that
delegate expected.

This is not a public header, so we don't care about compatibility. SDDM
does not use standard Qt roles like DisplayRole or DecorationRole, so
there's little reason for this sessions model to redefine them either.

We should better align this model class with SDDM::UserModel to reduce
confusion. Enum classes might be better for some tasks, but they aren't
widely used for Qt model roles, and they require extra casts without
added safety benefits.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Fushan Wen authored May 26, 2022 and Nate Graham committed May 30, 2022

CCBUG: 453166
CCBUG: 352476

Fushan Wen authored May 26, 2022 and Nate Graham committed May 30, 2022

CCBUG: 453166
CCBUG: 352476

Fushan Wen authored May 26, 2022 and Nate Graham committed May 30, 2022

When the panel is focused, clicking outside should make the panel
unfocused.

CCBUG: 453166
CCBUG: 352476

Fushan Wen authored May 26, 2022 and Nate Graham committed May 30, 2022

The second time pressing Meta+Alt+P, the panel should be unfocused.

CCBUG: 453166
CCBUG: 352476

Fushan Wen authored May 26, 2022 and Nate Graham committed May 30, 2022

It makes the code easier to be maintained across different platforms.

CCBUG: 453166
CCBUG: 352476

Th aspect ratio of thumbnails should follow the Plasmoid size, not the screen size.

BUG: 452308
FIXED-IN: 5.25

Otherwise there will be many redundant signal bindings.

Consider using std::find_if algorithm instead of a raw loop. (CWE-398)
in shell/shellcorona.cpp:1614

Consider using std::accumulate algorithm instead of a raw loop. (CWE-398)
in shell/shellcorona.cpp:1148

Consider using std::accumulate algorithm instead of a raw loop. (CWE-398) in shell/shellcorona.cpp:1051

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Luca Carlon authored May 27, 2022 and Nate Graham committed May 27, 2022

See the discussion in frameworks/plasma-framework!500.

BUG: 411462
BUG: 332512