1. 10 Oct, 2018 3 commits
  2. 09 Oct, 2018 1 commit
  3. 08 Oct, 2018 4 commits
  4. 07 Oct, 2018 1 commit
  5. 05 Oct, 2018 1 commit
  6. 04 Oct, 2018 3 commits
  7. 02 Oct, 2018 2 commits
    • Stefan Brüns's avatar
      [Bookmarks Runner] Remove duplicate results for bookmarks · e02f3fcb
      Stefan Brüns authored
      Summary:
      An entry from the moz_places db may have several referring entries
      in the moz_bookmarks db, i.e. where moz_places.id = moz_bookmarks.fk.
      One of these entries is the "main" entry, while the other ones are used
      for tags. Only the main entry has a title, while the others have not.
      The tag entries have the same type as the main entry, even the parents
      have the same type (folder).
      
      Another source for duplicate URLs are manually created bookmarks, e.g.
      in different folders. These may have the same or different titles.
      
      To remove these duplicates, merge all entries with the same URL. If a
      URL has multiple entries, keep all with distinct titles, otherwise keep
      at least one - a bookmark may have an empty title.
      
      See also T9626
      
      Test Plan:
      - Create a bookmark
      - Add one or more tags
      - Open FFs bookmarks sidebar
      - Copy and paste the new entry
      - Copy and paste the new entry again, change its title
      
      Search for the new bookmark. It should appear exactly twice, once
      with the original title, once with the modified one.
      Without patch, it appears 3 times, plus once more for each tag.
      
      Caveat: The bookmarks db has to be checkpointed to make the new
      entries visible in the main DB file.  To force checkpointing, execute:
      $> sqlite3 -column -header  ~/.mozilla/firefox/*.default/places.sqlite "PRAGMA wal_checkpoint"
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: broulik, davidedmundson, zzag, ngraham, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T9626
      
      Differential Revision: https://phabricator.kde.org/D15357
      e02f3fcb
    • Stefan Brüns's avatar
      [Devicenotifications Engine] Keep at most one notification per UDI · 17380886
      Stefan Brüns authored
      Summary:
      Each notification was created as new datasource, and was newer removed
      as long as the engine exists. This is especially bad for long living
      applets like the device notifier. As there can only be one notification
      per device (the last error state, or none), use the UDI as source name
      and update the contents.
      
      Also cancel (remove source) an old notifications in case of a successful
      setup, otherwise old error messages are shown in the device notifier.
      
      Test Plan:
      in Dolphin, select "Release" (context menu) for a mounted CD
      -> Notification in device notifier appears "Device can be safely removed"
      remount without ejecting
      -> Notification message is removed, device shows "mounted" emblem.
      
      Without the change, the message stayed and the device kept the notification
      emblem "(!)".
      
      Reviewers: #frameworks, broulik
      
      Reviewed By: broulik
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15892
      17380886
  8. 01 Oct, 2018 6 commits
    • Nate Graham's avatar
      Replace "Shutdown" with "Shut Down" in user-facing strings · b83e5ecc
      Nate Graham authored
      Summary:
      "Shutdown" is a noun ("The nuclear reactor is experiencing a shutdown!")
      
      "Shut Down" is an imperative command with a verb ("Shut down the nuclear reactor!"), which is how everything else is phrased.
      
      Test Plan:
      - Login screen button now says "Shut Down"
      - Searching for "shut down" in KRunner brings up the appropriate option ("shutdown" still works too)
      - KRunner says, "Shut down the computer"
      
      Reviewers: #vdg, #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15878
      b83e5ecc
    • David Edmundson's avatar
      Merge branch 'Plasma/5.14' · c0109051
      David Edmundson authored
      c0109051
    • David Edmundson's avatar
      dea0d82b
    • David Edmundson's avatar
      Fallback to in-process prompt if logout prompt fails · c2ea0afb
      David Edmundson authored
      Summary:
      KSmserver is currently very heavily tied to the shutdown prompt dialog.
      On upgrades a user ends up in a situation where they have an old
      ksmserver running but a newer shutdown dialog. This has caused issues
      repeatedly in the past.
      
      I want to make some changes to how the shutdown prompt is shown for
      5.15. First step is making the old releases more robust.
      
      Prompt looks ugly but a user will only see it at most once. Hopefully
      never.
      
      Test Plan:
      rm'd the greeter
      Got an ugly messagebox instead of nothing
      
      Reviewers: #plasma, broulik, ngraham
      
      Reviewed By: #plasma, broulik
      
      Subscribers: ngraham, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15869
      c2ea0afb
    • David Edmundson's avatar
    • David Edmundson's avatar
      Remove expensive blocking call on plasmashell startup · 0d3ffccb
      David Edmundson authored
      Summary:
      QDBusInterface is a blocking call that calls introspect. We don't need
      to introspect.
      
      As this is called on startup this call starts kuiserver, which means
      plasma is blocked whilst a whole process spawns, this is a lot worse
      than just a regular, ~100ms on my system
      
      Also using the generated versions is generally neater to read.
      
      Test Plan:
      Restarted plasmashell
      Copied a file
      Still had a spinny wheel
      Q_DBUS_BLOCKING_CALL_MAIN_THREAD_WARNING_MS=0 doesn't list kuiserver
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15815
      0d3ffccb
  9. 28 Sep, 2018 2 commits
  10. 26 Sep, 2018 2 commits
  11. 25 Sep, 2018 2 commits
  12. 24 Sep, 2018 1 commit
    • Stefan Brüns's avatar
      [Device Notifier] Avoid accessing attributes of stale UDIs · 61b2b173
      Stefan Brüns authored
      Summary:
      When a Solid device is removed (e.g. a CD is ejected) the notifier tries
      to read the attributes although the Source for the UDI has just vanished.
      
      Fixes several QML error messages, i.e. "TypeError: Cannot read property
      '...' of undefined" and "Unable to assign [undefined] to QString".
      
      Apparently these errors also have the effect of items showing outdated
      state, i.e. optical media still being shown after ejecting it.
      
      CCBUG: 394348
      
      Test Plan:
      1. insert optical medium
      2. eject
      Without the changes, the item was stuck
      Now, the item is removed as soon as the medium is ejected
      
      Also, no more errors are logged for the devicenotifier
      
      Reviewers: #frameworks, broulik
      
      Reviewed By: broulik
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15687
      61b2b173
  13. 21 Sep, 2018 2 commits
  14. 19 Sep, 2018 5 commits
  15. 17 Sep, 2018 3 commits
  16. 16 Sep, 2018 2 commits