Otherwise dragging a screenshot off a notification will immediately
trigger the default action.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

easier on the eyes if nothing else

we can connect two signals directly

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 192019
BUG: 341235
BUG: 344588
BUG: 394477
BUG: 397974
BUG: 397975
BUG: 403580
BUG: 417564
BUG: 420268
BUG: 429474
BUG: 431292
BUG: 444772
BUG: 446785
BUG: 447787
BUG: 448324
BUG: 448355
BUG: 451919
BUG: 451944
BUG: 454991

closes #23

The default image is set in MediaProxy ctor. When the default image is
still in loading status, the model image can change and be already
loaded before the default image is loaded, therefore there could be a
race condition that the default image is loaded later and overrides the
true image.

This stores the pending image and destroys the previous pending image
to fix the race condition.

BUG: 456189
FIXED-IN: 5.26

That way it's nicely centered in the parent window

Nicolas Fella authored Jul 01, 2022 and Nate Graham committed Jul 01, 2022

The login/logout script files need to be executable. To avoid the user
wondering why their script isn't executing, warn them if the file is not
executable and offer to fix it.

CCBUG: 391609

Given that the wayland protocol does not have window positions a recent
change to Qt development branch avoids having a mismatch of positions
and tells client code the window is at the topleft of the screen. This
fixes multiple bugs.

Unfortunately this breaks a few usages within plasma where a
side-channel sends that absolute positional information over a bespoke
protocol. Currently we proxy this all through QWindow geometry where the
new Qt behaviour will throw is askew.

Whilst our longterm plans are to find future options away from the
plasmashell protocol we may as well have our Qt6
build work given the patch is trivial and harmless.

It also allows for potential backporting if our software is
already secured against issues. Hence the cherry-pick.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

When the target size changes while the provider type is single image
or the current wallpaper is animated, the frontend is required to force
update the wallpaper.

It will be used to indicate whether the desktop is used in accent color
extraction.

CCBUG: 456038

After the culprit has been found, the hack is not needed anymore.

This reverts commit 8cfd0464.

CCBUG: 438114
(cherry picked from commit 68ed1677)

BUG: 449132

Instead of having Qt::red hardwired for the text colour.

New function KlipperPopup::showStatus() to implement setting
the filter line edit colours and showing the status.
Show an explicit error for an invalid regular expression.
Simplify filter regexp generation, add comment regarding case sensitivity.
No need to have single use strings as member variables.

I18N:

This can be the case, if one indexes the file content

BUG: 431603

Tanbir Jishan authored Jun 29, 2022 and Nate Graham committed Jun 29, 2022

Right now it opens the color picker dialog with the current first accent color.
Remembering the user's prior custom accent color (if any) is nicer.

BUG: 455894
FIXED-IN: 5.26

Derek Christ authored Jun 29, 2022 and Nate Graham committed Jun 29, 2022

This bug was introduced by !1754.

`lockScreenUi.hadPrompt` was set to `false` in `onFailed()` to avoid
unintentionally clearing the password after the text field had faded
out after 10 seconds and the user pressed a button. Unfortunately this
also caused the password field to not clear right after the failed event.

So instead the statement is moved into the trigger of `fadeoutTimer` which
fixes both issues.

BUG: 455227
FIXED-IN: 5.25.3

The panel was removed by a timer, which can cause null QScreen pointer.

BUG: 455328
FIXED-IN: 5.25.3

(cherry picked from ffadcb34)

GIT_SILENT

GIT_SILENT

David Edmundson authored Jun 17, 2022 and Nate Graham committed Jun 25, 2022

Whilst iterating through m_proccesses we make them finish. An existing
connect removes them from the vector.

Iterating through a volatile vector is unsafe.

BUG: 454159

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Tanbir Jishan authored Jun 24, 2022 and Nate Graham committed Jun 24, 2022

The custom color buttons don't need to be made conditionally transparent
or use a custom cursor, as they are mostly just normal radio buttons just
with a different background color. So let's remove these unnecessary
custom overrides.

Call `repaintNeeded` to update the accent color after the color is changed.

Felipe Kinoshita authored Jun 23, 2022 and Nate Graham committed Jun 23, 2022

BUG: 397966
FIXED-IN: 5.26

In task manager, switching between icon task manager and text task manager
loses the old settings, which is inconvenient. This copies the old
configuration to the new applet to fix that behavior.

BUG: 355588
FIXED-IN: 5.26