1. 31 May, 2020 1 commit
  2. 29 May, 2020 1 commit
  3. 28 May, 2020 1 commit
  4. 27 May, 2020 2 commits
    • Alexander Lohnau's avatar
      4e706dc6
    • Alexander Lohnau's avatar
      Bookmarks Runner: Fix extraction of firefox profile · a960c028
      Alexander Lohnau authored
      Summary:
      BUG: 418526
      
      The profile group with the value `Default=1` is not always the default profile, for example in the profiles.ini file from the bug report:
      ```
      [Profile1]
      Name=default
      IsRelative=1
      Path=dun5pnnn.default
      Default=1
      
      [Profile0]
      Name=default-default
      IsRelative=1
      Path=xewbk2mp.default-default
      
      [Install11457493C5A56847]
      Default=xewbk2mp.default-default
      Locked=1```
      
      In the text you can see that the profile with `dun5pnnn.default` has the value `Default=1`,
      but it is not  the default profile.
      The correct default profile is in the `[Install11457493C5A56847]` group with the key `Default`.
      
      Test Plan:
      If you create a new profile it will be extracted as the default profile
      (but the old value might still be cached see D28619).
      
      Reviewers: #plasma, ngraham, bruns, broulik, meven
      
      Reviewed By: meven
      
      Subscribers: meven, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29326
      a960c028
  5. 26 May, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Fix configuraiton read on Plasma start · 40b1a94a
      Konrad Materka authored
      System tray models are created lazily, so it is possible that the configuration will load earlier and not notify the model of the stored values. Add explicit configuration load, so that it always loads correctly during the initialization.
      
      This is a fix for regression introduced in the !14
      40b1a94a
  6. 25 May, 2020 2 commits
    • Konrad Materka's avatar
      [applets/systemtray] Consistent name/icon in System Tray settings · 04bd86e1
      Konrad Materka authored
      Summary:
      Icon and title of entries in System Tray settings should not change when status changes.
      Use only plugin's meta-data for consistent title and icon.
      
      BUG: 421561
      
      FIXED-IN: 5.19.0
      
      Test Plan:
      1. Check Weather or Media Player applets
      2. Enbable/disable/change status
      3. Icon and title should remain the same
      04bd86e1
    • Konrad Materka's avatar
      [applets/systemtray] Lazy initialize SystemTray model · 2ce60f4e
      Konrad Materka authored
      Summary:
      SystemTray model was created in constructor, delay initialization and
      create it lazily.
      The `SystemTray::appletAdded` signal is connected to both SystemTray's
      model and `Container`. `Container` must be connected first, because it sets
      some properties of newly added applet: `visible` to false and `parent`
      to the root item (container). If `Container` is connected second, then
      newly created applet ios added to the model and rendered, but immediately
      after that `Container` changes visibility to false.
      
      BUG: 420993
      
      Test Plan:
      1. Do not play anything (no Medial Player icon at all)
      2. Run Gwenview
      3. Check if Medial Player icon in hidden view is rendered correct.
      Before change:
      Sometimes icon is not rendered, looks like invisible or fully transparent.
      After change:
      Icon rendered correctly.
      2ce60f4e
  7. 24 May, 2020 2 commits
    • Konrad Materka's avatar
      [applets/mediacontroller] Icon for Playing/Paused · 220d3540
      Konrad Materka authored
      Add icon for Playing/Paused states, this partially reverts !16
      220d3540
    • Konrad Materka's avatar
      [applets/mediacontroller] Don't use Album Art for icon · 6f826a1b
      Konrad Materka authored
      Summary:
      Icon of Media Player applet is missing in the System Tray settings when
      the media playing has a cover. Such icon is present when nothing is playing.
      Fix by not using album art in any case - icon is not longer used in
      tooltip, can be static.
      
      BUG: 420197
      
      FIXED-IN: 5.19.0
      
      Test plan:
      1. play audio/video with a player compatible with Media Player applet
      2. open system tray settings during playback
      3. Icon of Media Player applet is always present in system tray
      settings, regardless of state.
      6f826a1b
  8. 21 May, 2020 2 commits
  9. 20 May, 2020 2 commits
  10. 19 May, 2020 1 commit
  11. 18 May, 2020 2 commits
  12. 15 May, 2020 3 commits
  13. 14 May, 2020 2 commits
  14. 13 May, 2020 6 commits
  15. 12 May, 2020 6 commits
  16. 11 May, 2020 6 commits
    • Eugene Popov's avatar
      [applets/notifications] Remain visible after removing all notifications while... · e6ed4a88
      Eugene Popov authored
      [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open
      
      Summary:
      When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself.
      
      BUG: 421344
      
      Reviewers: ngraham, plasma-devel, broulik
      
      Reviewed By: ngraham, broulik
      
      Subscribers: broulik
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29651
      e6ed4a88
    • Konrad Materka's avatar
      [applets/systemtray] Show base icon when AttentionIcon not set · 00e64bdb
      Konrad Materka authored
      Summary:
      If status is set to NeedsAttention it tries to use Attention Icon. If Attention Icon is not set, empty/null QIcon is set. QML can't check if QIcon is null or not, as a result it tries to use empty icon and nothing is rendered.
      Set null QVariant if AttentionIcon is not valid so that QML check will work correctly.
      
      Test Plan:
      * Set NeedsAttention as a status and with no Attention Icon
      * Base Icon should render correctly
      
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, mart
      
      Reviewed By: #plasma_workspaces, #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29544
      00e64bdb
    • Nate Graham's avatar
      [applets/icon] Remove icon from tooltip · 65f06786
      Nate Graham authored
      CCBUG: 420934
      
      Ref T12778
      65f06786
    • Arjen Hiemstra's avatar
      Use the right targets for KSysGuard · 8ae9b561
      Arjen Hiemstra authored
      Summary: Otherwise the build fails when things try to link to KF5::SysGuard etc.
      
      Test Plan: Builds again
      
      Reviewers: #plasma, meven
      
      Reviewed By: meven
      
      Subscribers: meven, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29628
      8ae9b561
    • David Redondo's avatar
      Improve StatusNotifierTest · 5459a533
      David Redondo authored
      Summary:
      Allows to set Icon, AttentionIcon and OverlayIcon either by name or pixmap.
      Makes it easier to test combinations of those.
      
      Reviewers: kmaterka, apol
      
      Reviewed By: kmaterka, apol
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29619
      5459a533
    • Marco Martin's avatar
      Redesign of system monitor plasmoids · c8deafbb
      Marco Martin authored
      Summary:
      Those plasmoids are intended to replace the old systemmonitor plasmoids
      They are based upon the new ksysguard daemon: see D28333 and D28141
      
      It has pluggable presets and sensor "faces" which are available from the KDE store
      
      Every preset is available as a separate plasmoid.
      By default are installed ones to replace
      roughly one by one the existing systemmonitor plasmoids so systems that use it
      will get the new ones in the updates
      
      Depends on D28922
      
      Test Plan: {F8209642}
      
      Reviewers: #plasma
      
      Subscribers: alexde, ngraham, davidedmundson, mmustac, ahiemstra, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28487
      c8deafbb