GitLab

You can't anchor to items that aren't the parent or sibling.

Summary:
This patch implements part of the mockup at T10470 by putting the power management
checkbox and settings button in a heading area visually connected to the titlebar.

In the process, I fixed a problem with the power management checkbox to make the layout's
spacing work: the checkbox now has text of its own, instead of living in a mouse area
with a separate label.

Test Plan:
{F8254807}
{F8254808}

Reviewers: #vdg, #plasma, broulik, niccolove, manueljlin

Reviewed By: #vdg, manueljlin

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T10470

Differential Revision: https://phabricator.kde.org/D29116

Niccolò Venerandi authored Mar 04, 2020 and Niccolò Venerandi committed Mar 04, 2020

Summary: A accidentally changed spacing with my previous commit

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27832

Niccolò Venerandi authored Feb 19, 2020 and Niccolò Venerandi committed Mar 04, 2020

Summary: With other two patches, this aims to make leftMargin consistent in widgets (See https://phabricator.kde.org/D26945 and https://phabricator.kde.org/D26944)

Test Plan:
System tray

Before:
{F7977382}
After:
{F7977379}

Notifications

Before:
{F7977359}
After:
{F7977357}

Battery monitor

Before:
{F7977362}
After:
{F7977361}

Self reminder: networkmanager is still slightly badly aligned

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: gvgeo, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26946

Summary:
Use QQC2.Slider, so that we have a moved signal. This way we can only
issue new brightnesses when the user actually interacts with it.
Don't adapt to the system brightness until we have finished interacting
with it.

Test Plan:
Manual testing, flickering is very much reduced both when scrolling over the
compact plasmoid as well as the slider.

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26035

Summary:
BUG: 345940

Move the "Enable Power Management" checkbox to the top of the window to match other applets (bluetooth, network)

Reviewers: #plasma_workspaces, broulik, mck182, davidedmundson, mart

Reviewed By: #plasma_workspaces, davidedmundson, mart

Subscribers: mart, jensreuterberg, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D8607

Calculate the plasmoid status and tooltips in a binding rather than invoking
Logic.updateFoo manually; this way we can have the QML engine do what it can do best.
Unfortunately it cannot look inside JS objects, so we cannot have the inhibitions
be handled the same way.

CCBUG: 360276

also port away from plasmapackage:/ urls when needed

Use Layouts where applicable and clean up a bit. Makes the code much easier to follow.
Also drop meaningless percentage for brightness as suggested by the usability team.

Just only show the OSD when the plasmoid isn't expanded.
Much simpler and what I wanted to achieve in the first place anyway.

Prevent a "You don't say" moment, only show the OSD when using the mousewheel on the tray icon
to provide feedback. Also make it more finegrained and allow 5% steps on the tray icon

Tooltips aren't particularly discoverable. This also refactors the code away from using
a string containing a HTML table (which doesn't play well with RTL languages) to a fancy
Array and a GridLayout that is shared between the battery tooltip and the main view

BUG: 337996
FIXED-IN 5.2.0

Listen for changes ourselves to make keyboard shortcuts make the slider move again

This finally allows us to have predictable sliders where a wheel whill always
result in a brightness change rather than having it go from 0 to 10 which is still
below 33% in case of 3 keyboard brightness steps resulting in no change whatsoever.
It also shows 0/3, 1/3, etc instead of percentage in such cases.

Also clean up a bit, remove superfluous clipping and prevent brightness change
on popup instantiation

Makes it look better (no empty gap) and given you can change brightness using keyboard
shortcuts and mouse wheel, the looks outweigh the additional mouse travel

BUG: 336708
FIXED-IN: 5.1

instead of the somewhat useless standard config dialog

BUG: 336707

This reverts commit a469d968.

This is consistent with what Plasma-NM does

I am really tired of this topic. Yes, the battery remaining time is not that accurate and
jumps around (the latter is something that could be fixed using a moving average). But if
we jump onto that train we would also need to remove the battery percentage itself as it's not
accurate either. 30% on a dead battery can quickly become 5% and then the notebook suddenly
turns off. "Battery: Present".

The remaining time is in the battery's tooltip, many distributions have even patched the
battery monitor to show the time by default, there's even a clone of the original battery
monitor on GHNS just with that option enabled; every other desktop environment even emphasizes
the remaining time, Windows prefers the time over percentage, Mac OS X allows you to put
the remaining time in the panel rather than the percentage, etc etc.

As a maintainer I now made the decision to show remaining time by default - it's no
"in your face" display but in the battery's detail section - and I would kindly
ask all the people involved in this discussion to respect this. Thank you!

BUG: 290578

BUG: 335537

- Batteries are now in a proper ScrollView since in Plasma 5 popups can not (yet?) be resized
- Get rid of that expanding thing for details, it was fancy and all in 4 but doesn't play well with 5
- Use ToolTip for battery details
- Remove redundant information (non-power supply display name is always vendor + model, no need to show these in the details again)
- Make icons medium size to be consistent with Plasma NM
- More refined spacing

use new icons in battery.svgz theme file. Also minor updates to improve icon with text vertical alignment.

REVIEW:118644
BUG:335377

This patch simplifies the battery's ui, and brings spacing in line with
Plasma 5 standards.

In detail:

- removing the selection item on batteries: it's already visible by the
  text shown that the battery is selected. It also doesn't need the
  selection semantics across the ui, because -- for what?
- remove separator lines, in Plasma 5, we use spacing for this case
- Improve HighDPI by removign hard-coded layout hints, use units.gridUnit
  throughout
- Fix batteryitem's status: it would show the wrong icon and time label,
  because AC Adapter can be empty. Checking charging is semantically
  correct here, since it uses the charge state, not the adapter state.
- remove a bunch of SVGs that were used internally to get margins -- use
  gridUnit for layout internal margins instead
- fix slider's right alignment, this would jump based on the percentage
  label's width, which varies per item. We know the rough length of the
  percentage label from the context, and can align the labels to that.

Thanks everybody for the reviews!

REVIEW:118272

This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:

http://community.kde.org/Frameworks/GitOldHistory

If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.

Branched from the monolithic repo kde-workspace, frameworks  branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0