GitLab

While unharmful (JS checks array bounds), these errors pollute log every
time the applet starts:

file:///usr/share/plasma/plasmoids/org.kde.plasma.keyboardlayout/
contents/ui/main.qml:16: TypeError: Cannot read property 'displayName'
of undefined
file:///usr/share/plasma/plasmoids/org.kde.plasma.keyboardlayout/
contents/ui/main.qml:17: TypeError: Cannot read property 'longName' of
undefined
file:///usr/share/plasma/plasmoids/org.kde.plasma.keyboardlayout/
contents/ui/main.qml:18: TypeError: Cannot read property 'shortName' of
undefined

CCBUG: 432029

BUG: 432032
FIXED-IN: 5.21

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

At the time this custom delegate was implemented, Kirigami.BasicListitem
didn't have the ability to easily display custom items inside itself.
Now it does, so we can port to that to save some code and increase
consistency.

The appearance is virtually identical and the UX remains the same with
the exception that you can now select an item by clicking anywhere on
the background, not just on one of the radio buttons.

We have no concept of selection in this list, so don't pre-select
the first item.

GIT_SILENT

GIT_SILENT

If you want git blame to ignore formatting revisions run:
git config blame.ignoreRevsFile .git-blame-ignore-revs

The result would be too disruptive

GIT_SILENT

onWheel is a bit messy with trackpads. It we just compare > 0 our scroll
rate is effectively determined by the refresh rate of the device. Use of
120 "wheels" is a common pattern used elsewhere.

Code is effectively copied from plasma-pa

The switch to previous/next direction I copied what was existing.

It's the only user of mobilecomponents in p-w and nothing actually appears to
set PLASMA_PLATFORM to "touch" anymore.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The back button needs to be reversed in order to make spatial sense in languages written right to left.

BUG: 431861

Return "layout" and "layoutsList" Properties where all layouts names are
now stored.
getLayoutLongName() DBus method is not used any more so it was also
deleted from DBus API in KWin and P-D, see corresponding commits there.

The Properties interface allows QML code be more declarative.
There is a trade-off though as now we have to:
- store all layout names on client side, even if it's not needed for
base QML layout component here
- duplicate layouts in layoutsList Property as they are also stored in
Action objects of the plasmoid in P-D.

Make mouse wheel layouts scrolling direction in a more natural way -
corresponding to layouts order in context menu

Accomodate API changes on server sides.
ID is not marshalling over DBus any more as it's just Index now.

Rework DBus API - getLayoutsList() now provides full details about the
layouts.
Remove Q_PROPERTY's as they are not make much sense here.
Port to a fully event-driven interface towards QML.

Use the same URL used mostly everywhere else.

This got removed in d82513ce as I thought a user would
always have a "Root" entry, leading to "Root/foo" paths.

However, if you hide a place, it will naturally not be considered for `closestItem`
resulting in the final `QUrl::toDisplayString` being hit, giving us a not so
nice `file:///` URL.

When rotated most applets, especially text look garbage.

If we render into an offscreen buffer we can smooth things out and it
looks good again. There is a performance penalty to this, but most
people do no not rotate plasmoids.

In case an application happens to issue multiple close commands in the
time between we record the first close and it actually being processed.

This reverts commit 49346b0b

It broke the wayland session as it picks up WAYLAND_DISPLAY, DISPLAY and others
from dead sessions and also seems to cause other issues, see discussions on
!487

A new instance WidgetExplorer is created everytime we open get new
applets window. Each and every instance of WidgetExplorer has its own
newStuffDialog. This means that downloadWidgets method will always
create new instance of QtQuickDialogWrapper due to the default value of
newStuffDialog is null.

Change newStuffDialog to static so that it will be shared to every
instances of WidgetExplorer. This prevents another get new applets
window to be opened.

BUG: 412765

While this was in principle a good idea to keep active jobs at the top of the
history, it can cause unwanted dialog shifts and dialog recreation when there
are two jobs and the first one finishes and then the second one finishes.

When this was ported to C++, it missed the actual variable assignments.

This ensures that there are no shadows during teardown.

It means "current directory" anyway, so it's redundant and ugly.

When running clang-format these includes will get reordered
and the build will fail. This commit prevents this from happening.

BUG: 408606

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The QWidgets components are about to be deprecated
and the QtQuick dialog has a bunch of visual improvements.

Considering that most KCMs already use the QtQuick components
this MR improves the consistency.

See frameworks/knewstuff!80
for the MR which introduced the non-deprecated dialog class.

Without this, the virtual keyboard appears and takes focus, which
doesn't make sense:the password field needs to retain focus or else
the keystrokes you type using the virtual keyboard get eaten.

BUG: 430209
FIXED-IN: 5.21

the Text.Fit sizing policy will size the font in order to fit given a fixed
size of the label, but it can't really cause the other way around which we need:
cause a vertical resize in order to accomodate a larger font.
In order to fake that, we fix the date label to an arbitrary tall height
(will overflow outside the applet) and then size the applet based on the label contentheight instead,
leaving the invisible part of the label outside.
In order to avoid the huge text it used to have, limit the maximum size to an arbitrarly
small value, in this case
Math.min(0.7 * timeLabel.height, theme.defaultFont.pixelSize * 1.4)

BUG:417852
FIXED-IN: 5.21

Counterpart commit with the same title is in P-D

For some reason beyond me when all elements in the JobItem turn invisible,
e.g. when a job finishes (its progress bar hideS), and there are no action
buttons (e.g. when a job fails), the Loader does not collapse properly.