GitLab

For these delegates, the width is computed automatically and correctly
from the parent ListView's width, taking into accounts margins and
scrollbar visibility.

Because that's annoying. This change was made to other applets in
plasma/plasma-desktop!812.

Fabian Vogt authored Jan 21, 2022 and Nate Graham committed Jan 23, 2022

SessionManagementScreen needs to be a FocusScope, so that when it gets focused
directly (through the StackView), it directs it to the proper control inside
instead of stealing it from them.

This fixes initial focus of the controls in the SDDM theme.

BUG: 447817

BUG: 442463
FIXED-IN: 5.24.0

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Double-quoted multi-line strings is a custom Qt/JS engine extension, and
as such it is better be avoided, since we have official widely
supported replacement.

GIT_SILENT

David Edmundson authored Jan 13, 2022 and Fabian Vogt committed Jan 21, 2022

If invoked on gnome we should always return success
this is because a desktop file that has X-KDE-AutostartCondition
probably has an X-Gnome- equivalent and we only want one to run
this would match non systemd behaviour.

See also: https://github.com/systemd/systemd/pull/22115

This is something that came up in the monthly VDG meeting: the desktop
context menu has a lot of stuff in it, and we're looking to slim it down
where possible so it isn't so overwhelming.

One potential target is the Activities menu item, which has no real use
for a user who isn't using activities. We can never be 100% sure, but if
there is only one activity, it's a good bet the user isn't using the
feature. In this case, we can hide the menu item that shows the
switcher, because there's nothing to switch to!

Now, the switcher also has a button to add new activities, so it could
be argued that this change makes activities less discoverable. However
the feature is shown pretty prominently in the commonly-accessed
Workspace Behavior group in System Settings, so I think it's already
discoverable enough.

Test plan:
- Have one activity and right-click on the desktop > See no menu item
- Create a second activity and right-click on the desktop > See it

Here's how the menu looks now when there is only one activity:

![smaller_now](/uploads/5b53fe7b3f3937c8c413206f8e179768/smaller_now.png)

cc @teams/vdg @ivan

We don't really use the word "notebook" in other places.

Bharadwaj Raju authored Jan 21, 2022 and Nate Graham committed Jan 21, 2022

![Screenshot_20220121_101827](/uploads/c0d273978ba6b7374c1dc8062a3a210d/Screenshot_20220121_101827.png)

Cyril Rossi authored Jan 21, 2022 and Marco Martin committed Jan 21, 2022

An UI to manage Screen assignment of Containments, the main use case is to recover lost or inactive panels from a display that you can no longer access.

qml part: plasma-desktop!618

related to https://phabricator.kde.org/T14346

CCBUG: 447044

Access the dialog from Toolbar in Edit Mode (Manage containments)
![Screenshot_20211222_114140](/uploads/31379781e3315a612d695220e623353b/Screenshot_20211222_114140.png)

![Screenshot_20211217_095945](/uploads/f890d5ac9f3ee6e82991d325b3078f5b/Screenshot_20211217_095945.png)


To show the dialog, simply enter in `edit mode`, then you can :
* See known displays and their panels and desktops, the dialog automatically update when adding/moving/removing a panel.
* Delete a panel or a desktop
* Recover a panel by moving it to an active display (click on move icon, then select the proper action in drop menu)
* Recover a desktop by moving it to an active display, in fact, this will swap it with th targeted desktop
* Modifications are automatically applied

What I've tested:
* Adding a panel, adding some applet on it. Then disabling its display, open the dialog and move it to an active display, restarting session, the panel is here with its applet.
* On another display, add applets (sticky note) on the desktop. Disable this display, open the dialog and move it to an active display, restart session, both desktop were swapped and you see the background (if different) and sticky note available.

Bharadwaj Raju authored Jan 21, 2022 and Nate Graham committed Jan 21, 2022

BUG: 448727
BUG: 448728
FIXED-IN: 5.24

applets/clipboard: Fix unknown character when pressing Backspace while an item in the list has focus

The original condition will turn the text in the search field into an
unknown character. Move the logic to switch-case to fix the condition.

BUG: 448819

We had all of this wired up correctly in the backend, it just turns out
that we overwrite all messages with "Unlocking failed" immediately.

BUG: 428613

This reverts commit 5c8816dd

In containmentconfigview.cpp, "Plasma/Wallpaper" is checked if a plugin
is of ServiceType Plasma/Wallpaper.

BUG: 448625
FIXED-IN: 5.24

So Up/Down key can navigate the list items instead of scrolling in
the ListView.

CCBUG: 448811

ListView will absorb the key events, so `Keys.onPressed` in
ClipboardPage will not receive the event. Instead we should connect
those key events to `arrowKeyPressed()`.

BUG: 448811

The behavior may cause unexpected results when the user spam press Del
in order to delete all characters in the search field, and find that
all items in the list are deleted.

It also causes pressing Del in the search field not deleting the fully
selected text.

BUG: 448738
BUG: 448739

This makes it use a more KDE-ish style so that it fits in with the
rest of the system a bit better.

PlasmoidPopupsContainer.qml has special code to handle merging headers
from applets if those applets use a PlasmaComponents3.Page instance as
their FullRepresentation. However this breaks for any applets that use
PlasmaExtras.Representation, which is a subclass of it that we have been
porting applets to over time, because it offers more features in a
single location. This caused the detection to break, so such applets
woudl have their headers improperly merged.

Explicitly detecting the use of PlasmaExtras.Representation as well
fixes it.

BUG: 438178
FIXED-IN: 5.24

No more one/many hints discrimination. They can all live happy together,
under single Repeater, using model directly. When the model will
migrate to a real Qt AbstractModel subclass (e.g. QML ListModel),
delegate's properties code will need to be adjusted again though.

No more back-propagating representation into logic.

Speaking of context properties, let's also get rid of magic lookups
within file's context.

Pass down laptop's lid action inhibition all the way from the top-level
file to reduce dependency on sketchy context properties and make
components more self-contained.

"Fix" as in "repair and make it right". This commit actually makes
 header dynamic as it was always supposed to be. Wrongly fixed height
 with dummy empty padding at the bottom was the result of incorrectly
 applied anchors within Container[1]'s contentChildren.

 [1]: PlasmoidHeading is a TabBar which inherits from Container and Control.

Technically it doesn't matter, since they are mutually exclusive anyway.
But for the upcoming refactoring it will be a bit easier to see what's
going on if they'll be close to each other.

Semi-automatic GitLab's rebase didn't work out well for this use case.

It's just refactoring.

Typically we have properties on top, then functions, then signal
handlers, then child items, then the onCompleted: block. The Battery
Monitor didn't conform to that, so this commit makes it do so. There are
no actual code changes; stuff is simply moved around for greater clarity
and style standardization.

If neither batteries nor brightness controls are present, set the title
to "Power Management".

f9e39815 ("applets/batterymonitor: Improve for desktop systems") changed the
plasmoid to use a plain icon instead of the CompactRepresentation if there are
no batteries.
While 471cc374 ("applets/batterymonitor: fix CompactRepresentation") brought
the use of the CompactRepresentation back, the plain icon is still used.

For the case that there are no batteries and brightness controls available,
it fell back to "battery", which has no symbolic variant. Change that to use
the symbolic "video-display-brightness" as well.

BUG: 448520

ivan tkachenko authored Jan 16, 2022 and Nate Graham committed Jan 18, 2022

It used to have inconsistent types depending on internal conditions
(sometimes double, sometimes int), but now it's fixed.

ivan tkachenko authored Jan 15, 2022 and Nate Graham committed Jan 18, 2022

In other places both properties are being set unconditionally, so this
patch just aligns it to other code. Also, possibly fixing scenario
where the Sources property might de-synchronize because the code
conditionally skipped updating it.

ivan tkachenko authored Jan 15, 2022 and Nate Graham committed Jan 18, 2022

...to clarify its purpose and return type.

ivan tkachenko authored Jan 15, 2022 and Nate Graham committed Jan 18, 2022

It is outdated, deprecated and inefficient.

This way we no longer crash in kcmutils, because a space is an invalid character for the
DBus registration. While it is fixed in kcmutils 397763b0189f8a61c340e30959391f169ecfa0d, this commit
has not landed in the latest frameworks release.

The only issue is that the plugin would be re-enabled in case it was disabled by the user, because the plugin id is different.
However this runner is not aggressive in the amount of matches it displays, I do not consider this a big issue.

The new plugin Id gets derived from the filename.

BUG: 448156

When you unmount a device using the UI, the device shows a message
saying, "Removing..." This message remains visible as long as the device
is still processing file move or copy operations due to the use of async
file IO. The device is not yet safe to unplug as long as the message is
visible, but this is not obvious from the UI. As a result, it is
possible for people to think it's stuck and unplug it anyway, causing
data loss.

This commit attempts to address that by showing a different message when
the unmount takes more than one second, which tells the user what is
actually happening and explicitly asks them not to unplug it yet.

Test if the text is correctly trimmed, and can still provide the full
text.