GitLab

Fushan Wen authored May 21, 2022 and Marco Martin committed Jun 14, 2022

It fixes that when there are multiple calendar applets, each applet
doesn't have its own EventPluginsManager.

BUG: 454846
FIXED-IN: 5.26

Aleix Pol Gonzalez authored Mar 30, 2022 and Aleix Pol Gonzalez committed Mar 31, 2022

It's a Qt 5 bug that target cannot take an attached object as a value
there. It's the reason why Plasmoid.self was introduced in the first
place.

Aleix Pol Gonzalez authored Mar 06, 2022 and Nate Graham committed Mar 08, 2022

That is, from using plasmoid the ContextProperty to Plasmoid the
attached property.

Fushan Wen authored Dec 29, 2021 and Nate Graham committed Jan 04, 2022

It makes the icons more consistent.

Fushan Wen authored Dec 25, 2021 and Nate Graham committed Dec 26, 2021

Their names have been changed in 5.24, so change to their new names.

BUG: 447502

don't set layout size hints from the contents size. this will cause
binding loops. use the implicit size instead.
This solves an issue visible especially on wayland (different roundtrip of timing of resizes in x11 seems to mask this problem) where the clock tooltip
sometimes gets stuck in an infinite resize loop freezing the whole plasma shell
BUG:422072

Felipe Kinoshita authored May 25, 2021 and Nate Graham committed May 25, 2021

A real ellipsis character is better for accessibility, as screen readers
will describe it appropriately.

The context property version is slower to access and won't be supported
in Qt6. Let's port away from it and use the singleton version instead.

Here was my full process for making this change:

1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
2. Verified no more occurrences with `grep -r " units."`
3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+   " | grep "//"`
4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done`

This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.

Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.

Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked

Summary:
CCBUG: 417836

Depends on D29711

As this will depend on Frameworks 5.71, it will be landed on master after branching,
ending up in Plasma 5.20.

Test Plan:
Right-click on applets and activate their configure menu items
Open applets and click on their settings buttons
Observe that the KCMs are opened in System Settings or Info Center
(depending on the context)

Reviewers: mart, #plasma

Reviewed By: mart, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29712

Summary:
Right now time zones are only shown in the tooltip, which is annoying since the tooltip
times out aftew a few seconds, so it often closes before I can find the timezone I'm
looking for.

This patch adds a view for the current tomezones in the expanded representation, and
implements a mockup in https://bugs.kde.org/show_bug.cgi?id=395655 showing a proposal
for how to present this information.

The Expanded Representation is also ported to Layouts in order to make this task easier.

FEATURE: 395655
FIXED-IN: 5.19.0

Test Plan:
Just calendar: {F8157434}

Calendar + events: {F8157435}

Calendar + time zones: {F8157436}

Calendar + events + time zones: {F8157437}

Reviewers: #vdg, #plasma, cblack

Reviewed By: #vdg, cblack

Subscribers: cblack, apol, plasma-devel

Tags: #plasma

Maniphest Tasks: T9222

Differential Revision: https://phabricator.kde.org/D27903

Summary:
support the automatic shadow hint

When the hint is shadowedBackground, do an automatic shadow with a shader, and
change applet's color to complementary

Test Plan:
Tested the functionality on various applets. To test, the digital clock is enabling explicitly background configurability
{F7788553}

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25591

Bernhard Schiffner authored Apr 11, 2018 and Kai Uwe Broulik committed Apr 11, 2018

BUG: 355190
FIXED-IN: 5.13.0

Differential Revision: https://phabricator.kde.org/D6183

Summary:
on Qt 5.6/5.7 changed signal was emitted at startup as well,
triggering plasmoid.configuration.onSelectedTimeZonesChanged
in Qt 5.8 this doesn't happen, giving an empty clock at startup
this makes sure allTimezones gets built

Test Plan: with Qt 5.8 the clock is shown correctly

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2946

Summary:
on Qt 5.6/5.7 changed signal was emitted at startup as well,
triggering plasmoid.configuration.onSelectedTimeZonesChanged
in Qt 5.8 this doesn't happen, giving an empty clock at startup
this makes sure allTimezones gets built

Test Plan: with Qt 5.8 the clock is shown correctly

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2946

Summary:
We need Local to be *always* present, even if not disaplayed as
it's used for formatting in ToolTip.dateTimeChanged()
this makes sure local is always in the connected sources, even if
it's not explicitly shown to the user

Test Plan:
tested, local timezone is not shown in clock/tooltip when
selected, and no warnings from dateTimeChanged()

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2936

Summary:
We need Local to be *always* present, even if not disaplayed as
it's used for formatting in ToolTip.dateTimeChanged()
this makes sure local is always in the connected sources, even if
it's not explicitly shown to the user

Test Plan:
tested, local timezone is not shown in clock/tooltip when
selected, and no warnings from dateTimeChanged()

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2936

Summary: org.kde.plasma.digitalclock/contents/ui/main.qml:51: TypeError: Cannot read property 'width' of null

Reviewers: mck182, hein

Reviewed By: hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D1840

Remove the context menus that would do nothing if access to those KCMs is restricted.

Differential Revision: https://phabricator.kde.org/D1632

This reverts commit 697aaf80
and brings back the agenda part of calendar.

REVIEW: 127734
BUG: 357642
BUG: 349676
FIXED-IN: 5.7

In kde4 times, the layout of clock's tooltip was nicely arranged using a
table. Now it's a bit of a mess so this brings back some nice layout.

Also simplifies the timeForZone function which is used only for the
tooltip.

BUG: 357005
BUG: 351472
CCBUG: 357004
FIXED-IN: 5.6.0
REVIEW: 124047

When the user selects another timezone and deselects the current one,
the clock timezone should change immediately.

REVIEW: 125709
BUG: 353996
BUG: 348612

REVIEW: 124451
FEATURE: 348080
FIXED-IN: 5.4.0

REVIEW: 124021
BUG: 348738
FIXED-IN: 5.4.0

This was added for KDeclarative 5.9 which we already depend on, so let's
just use it. Battery applet already does.

Backports parts of f5a177b6

BUG: 347032
FIXED-IN: 5.3.1

It collides with the compact representation item and breaks things.

BUG: 346841
FIXED-IN: 5.3.1

REVIEW: 123372
BUG: 346033

This also allows to increase the polling interval to 60 seconds

REVIEW: 122592
BUG: 343872
FIXED-IN: 5.3.0

Still has couple missing features:
* no time in the tooltip yet (needs larger refactor)
* no order selection
* no default timezone (but last used is always saved)
* couple minor issues

REVIEW: 120314
CCBUG: 337564

There's no reason to duplicate it into "Date" and "Time", "DateTime"
will work just fine. Plus QTime and QDate have no idea about timezones.

CCBUG:336291

This requires a simple plugin to actually launch the new process

BUG: 334757

This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:

http://community.kde.org/Frameworks/GitOldHistory

If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.

Branched from the monolithic repo kde-workspace, frameworks  branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0