Plasma Workspace merge requestshttps://invent.kde.org/plasma/plasma-workspace/-/merge_requests2023-03-06T19:42:33Zhttps://invent.kde.org/plasma/plasma-workspace/-/merge_requests/836Port system tray away from SNI dataengine2023-03-06T19:42:33ZKonrad MaterkaPort system tray away from SNI dataengineFirst iteration, just port away from DataEngine. It leads to some code duplication, but it is needed to preserver backward compatibility. I plan to modify it in the future - for example move some icon rendering into QML.
CC: @martFirst iteration, just port away from DataEngine. It leads to some code duplication, but it is needed to preserver backward compatibility. I plan to modify it in the future - for example move some icon rendering into QML.
CC: @mart5.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/953[Media Player] Skip source if it doesn't exist2023-01-20T20:14:58ZKai Uwe Broulik[Media Player] Skip source if it doesn't existWe get `sourceRemoved` emitted before the source is actually removed
from the list.
This is a regression from 5984d4960fa5ecf60a20b1fbc782fb841faa4af7
in plasma-framework but better be safe than sorry.
BUG: 439309
FIXED-IN: 5.23.3
---...We get `sourceRemoved` emitted before the source is actually removed
from the list.
This is a regression from 5984d4960fa5ecf60a20b1fbc782fb841faa4af7
in plasma-framework but better be safe than sorry.
BUG: 439309
FIXED-IN: 5.23.3
---
@davidedmundson @kmaterka
I think we need to fix that commit too to be:
```
d->sources.erase(it);
Q_EMIT sourceRemoved(source);
s->disconnect();
s->deleteLater();
```
I would not expect something to still be listed if I got a removal signalled...
I wonder if that is also what made media controls in Task Manager unreliable, though it doesn't use `sourceRemoved` explicitly and already checks for `.data[source]` being not undefined5.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1177Improve startplasma processes to make sure they deal properly with SIGTERM2022-01-27T16:18:40ZAleix Pol GonzalezImprove startplasma processes to make sure they deal properly with SIGTERMWhile debugging SDDM, I realised there were some occasions when we were not cleaning up the logind sessions, this showed there were some processes we were not ever telling them to close.
This adds 2 changes fundamentally:
* Makes sure s...While debugging SDDM, I realised there were some occasions when we were not cleaning up the logind sessions, this showed there were some processes we were not ever telling them to close.
This adds 2 changes fundamentally:
* Makes sure startplasma itself terminates its own processes.
* Allows plasma_session to terminate its own processes.
A good way to test this is to restart a plasma session several times and use loginctl to see how they're listed.5.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1015Trim very large text strings in Klipper history view2022-01-18T14:41:48ZValdikSS ValdikSSTrim very large text strings in Klipper history viewKlipper may freeze the whole plasmashell for tens of seconds trying
to render very long text string from history in the popup.
Trim very large strings to 200 characters (tooltip default) to prevent this.
BUG: 431673Klipper may freeze the whole plasmashell for tens of seconds trying
to render very long text string from history in the popup.
Trim very large strings to 200 characters (tooltip default) to prevent this.
BUG: 4316735.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1017applets/appmenu: assorted bugfixes2022-01-09T03:09:50ZJan Blackquillapplets/appmenu: assorted bugfixes- make mnemonics work again, without errors or stray &s
- make delegate stay down while appmenu is open- make mnemonics work again, without errors or stray &s
- make delegate stay down while appmenu is open5.23Jan BlackquillJan Blackquillhttps://invent.kde.org/plasma/plasma-workspace/-/merge_requests/266[applets/globalmenu] Look more menu-y2022-01-08T16:38:15ZJan Blackquill[applets/globalmenu] Look more menu-yThe global menu applet now looks more like a regular menubar, due to
- Using the new menuitem SVG element introduced in frameworks/plasma-framework!89
- Removing spacing between menu items
Before:
![IMG_20200916_110641_960](/uploads/41...The global menu applet now looks more like a regular menubar, due to
- Using the new menuitem SVG element introduced in frameworks/plasma-framework!89
- Removing spacing between menu items
Before:
![IMG_20200916_110641_960](/uploads/414e224b5d9c4e640f18fcd36cfc1aac/IMG_20200916_110641_960.png)
After:
![IMG_20200916_110645_780](/uploads/4d5b4fa12f4b82ee8c014f4a850b3941/IMG_20200916_110645_780.png)5.23Jan BlackquillJan Blackquillhttps://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1300[webshortcutsrunner] Fix private browsing with some Firefoxes2021-12-25T00:31:44ZNicolas Fella[webshortcutsrunner] Fix private browsing with some FirefoxesBecause we can't have nice things the private browsing action in Firefox
sometimes has a %u placeholder for the URL and sometimes doesn't.
The current code only accounts for the case without placeholder, which
is also what Chrome does.
...Because we can't have nice things the private browsing action in Firefox
sometimes has a %u placeholder for the URL and sometimes doesn't.
The current code only accounts for the case without placeholder, which
is also what Chrome does.
Replace the placeholder if found, otherwise append the URL5.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1285[kcms/style] Don't call setNeedsSave when style config changes2021-12-24T21:54:53ZNicolas Fella[kcms/style] Don't call setNeedsSave when style config changesThe style config is saved already when the dialog closes so enabling the KCM apply button doesn't make sense
The comment suggests that this is done for a reason, but the style preview seems to refresh correctly even with this patch
BUG...The style config is saved already when the dialog closes so enabling the KCM apply button doesn't make sense
The comment suggests that this is done for a reason, but the style preview seems to refresh correctly even with this patch
BUG: 4392975.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1306digital-clock: fix calendar popup contrast when opened from desktop2021-12-24T18:01:15ZNoah Davisdigital-clock: fix calendar popup contrast when opened from desktopBUG: 446991BUG: 4469915.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1294[libnotificationmanager] Fix memory leak2021-12-19T11:15:52ZFushan Wen[libnotificationmanager] Fix memory leakIn an &operator= we already have an object. It will have the d-pointer
already allocated.
If we create a new private implementation our old one leaks
(cherry picked from commit 079552b315752d775d0d9e250e0651ba1cb0096c)In an &operator= we already have an object. It will have the d-pointer
already allocated.
If we create a new private implementation our old one leaks
(cherry picked from commit 079552b315752d775d0d9e250e0651ba1cb0096c)5.23Fushan WenFushan Wenhttps://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1266[Global Menu] Set translation domain2021-12-13T12:36:51ZKai Uwe Broulik[Global Menu] Set translation domainEnsures `i18n` in C++ side of things works
---
Untested but straightforward, `Messages.sh` already extracts from `.cpp`
@cblackEnsures `i18n` in C++ side of things works
---
Untested but straightforward, `Messages.sh` already extracts from `.cpp`
@cblack5.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1261[KSplash] Start with zero opacity2021-12-10T17:57:22ZKai Uwe Broulik[KSplash] Start with zero opacityThe `introAnimation` only kicks in at stage 2 so you might catch a
glimpse of the logo before its fade-in animation starts.
---
My ksshaskpass prompt no longer shows ontop of a Plasma logo which then disappears and fade in again.
Prob...The `introAnimation` only kicks in at stage 2 so you might catch a
glimpse of the logo before its fade-in animation starts.
---
My ksshaskpass prompt no longer shows ontop of a Plasma logo which then disappears and fade in again.
Probably good for stable?5.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1264lookandfeel: Add missing check if list of files is empty2021-12-08T17:34:42ZAlexander Lohnaulookandfeel: Add missing check if list of files is emptyBUG: 439797BUG: 4397975.23Alexander LohnauAlexander Lohnauhttps://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1250Fix Klipper Actions content truncation2021-12-05T16:58:02ZValdikSS ValdikSSFix Klipper Actions content truncationCommit f9669af2 introduced a regression with Klipper Actions: it used
truncated text as a source for the action, which resulted in truncated
output.
BUG: 444365Commit f9669af2 introduced a regression with Klipper Actions: it used
truncated text as a source for the action, which resulted in truncated
output.
BUG: 4443655.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1249[klipper] Use full text for DBus return values2021-12-05T15:10:15ZDavid Edmundson[klipper] Use full text for DBus return valuesIn a recent commit HistoryItem::text() became the visual representation
of the mimedata; often a truncated string.
mimeData()->text() always returns the full value.
BUG: 446441In a recent commit HistoryItem::text() became the visual representation
of the mimedata; often a truncated string.
mimeData()->text() always returns the full value.
BUG: 4464415.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1166systemtray: Check if a service is already added before processing QDBusReply2021-11-20T13:16:18ZFushan Wensystemtray: Check if a service is already added before processing QDBusReplyDue to async nature of `QDBusPendingReply`, services could be already registered by `QDBusServiceWatcher` when the pending reply takes a long time to finish, so it's possible that `QDBusServiceWatcher::serviceRegistered` signal is emitte...Due to async nature of `QDBusPendingReply`, services could be already registered by `QDBusServiceWatcher` when the pending reply takes a long time to finish, so it's possible that `QDBusServiceWatcher::serviceRegistered` signal is emitted before the pending reply emits `QDBusPendingCallWatcher::finished`, which will make the same service added twice and crash plasmashell.
We need to check if a service is already added in `m_sniServices` before processing registered items in `QDBusReply`.
Thank @kmaterka for pointng out the right fix.
BUG: 443961
FIXED-IN: 5.23.45.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1176Use implicit size to not cause binding loops2021-11-03T18:20:08ZMarco MartinUse implicit size to not cause binding loopsdon't set layout size hints from the contents size. this will cause
binding loops. use the implicit size instead.
This solves an issue visible especially on wayland (different roundtrip of timing of resizes in x11 seems to mask this prob...don't set layout size hints from the contents size. this will cause
binding loops. use the implicit size instead.
This solves an issue visible especially on wayland (different roundtrip of timing of resizes in x11 seems to mask this problem) where the clock tooltip
sometimes gets stuck in an infinite resize loop freezing the whole plasma shell
BUG:4220725.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1163wayland: don't create DesktopView for placeholder screen2021-11-03T16:45:25ZOxalica --wayland: don't create DesktopView for placeholder screenThis fix crash when turn off and on the only primary display.
The bug https://bugs.kde.org/show_bug.cgi?id=438839 is currently marked as resolved but actually NOT.
I tested this MR and it should really be fixed now.This fix crash when turn off and on the only primary display.
The bug https://bugs.kde.org/show_bug.cgi?id=438839 is currently marked as resolved but actually NOT.
I tested this MR and it should really be fixed now.5.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1169[startplasma] Detect systemd service in linked state2021-11-02T06:48:47ZOxalica --[startplasma] Detect systemd service in linked stateSystemd units which are symlinked to the service directory will be in
`linked` or `linked-runtime` state. They are also available and
runnable. This can happen when the package manager uses symlinks to
install systemd units instead of co...Systemd units which are symlinked to the service directory will be in
`linked` or `linked-runtime` state. They are also available and
runnable. This can happen when the package manager uses symlinks to
install systemd units instead of copying them, like on NixOS.
Related: https://github.com/NixOS/nixpkgs/pull/1440985.23https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1167[Notifications] Fix grouping container side line2021-11-01T20:01:25ZKai Uwe Broulik[Notifications] Fix grouping container side lineBase the width on the actual thickness of the SVG provided by the theme,
otherwise it might get stretched way too much.
---
Plasma theme changed but having used `iconSizes.small` for this was wrong.
Now looks like this again (didnt te...Base the width on the actual thickness of the SVG provided by the theme,
otherwise it might get stretched way too much.
---
Plasma theme changed but having used `iconSizes.small` for this was wrong.
Now looks like this again (didnt test low dpi)
![Screenshot_20211101_205552](/uploads/3bcb69414b1ed8f7504e51dd6519a155/Screenshot_20211101_205552.png)5.23