Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 18
    • Issues 18
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 99
    • Merge requests 99
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Workspace
  • Merge requests
  • !147

Open
Created Jul 10, 2020 by Bhushan Shah@bshah📱Developer
  • Report abuse
Report abuse

Refactor the notifications watcher interface

  • Overview 25
  • Commits 2
  • Changes 5

After adding it in 5.19 release, we realized various shortcomings of the NotificationsWatcher interface. After discussing this with @broulik and @nicolasfella at last Plasma Sprint this is work in progress attempt to refactor it.

Main changes

  • Explicit Register/UnRegisterWatcher methods from the notifications manager interface is removed.
  • Registrations of watcher is handled by the "plugin" files installed on filesystem
  • Plugin file is simple .desktop file, example below

These changes opens up possibility of ability to enable/disable the notification watcher based on user's selection/choice. I have not thought about user interface for this just yet though, maybe needs talking with VDG about this.

Examples

Lock-screen

[Desktop Entry]
Name=Lock Screen
Type=Service
Icon=lock
Id=org.kde.kscreenlocker.greeter
X-KDE-Notifier-DBus-Service=org.kde.kscreenlocker.greeter

KDE Connect

[Desktop Entry]
Name=KDE Connect
Type=Service
Icon=kdeconnect
Id=org.kde.kdeconnectd
X-KDE-Notifier-DBus-Service=org.kde.kdeconnectd
Edited Jul 28, 2020 by Nicolas Fella
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/bshah/notifications-watcher-refactor