Skip to content

Revert "startplasma-wayland: Don't set GDK_SCALE and GDK_DPI_SCALE"

Nate Graham requested to merge ngraham/plasma-workspace:revert-removal-of_GDK_SCALE-envar into master

This reverts commit 63de3d6f.

This change was incorrect and the original logic for it was backwards; it was stated that keeping it causes non-GTK XWayland (e.g. Electron) apps to be scaled incorrectly. But in fact the opposite was true; getting rid of it was what causes them to be scaled incorrectly! This mistake was made due to due to the presence of a local workaround on my system that inverted the behavior.

See upstream bug report: https://github.com/electron/electron/issues/37312

BUG: 465733 FIXED-IN: 5.27.1

CCBUG: 443215

This change will undo the fix for https://bugs.kde.org/show_bug.cgi?id=443215, so I'll fix it another way once it's merged.

Test plan

  1. Set scale to something higher than 1 on any screen
  2. Make sure you're using the default XWayland client scaling setting in the KScreen KCM
  3. Launch Element, Discord, VSCode or another Electron-based app

Before, the app would be drawn at a size equal to (1/the highest scale factor), rather than the scale factor.

With this MR, it's shown at the correct scale for the screen it's located on.

Merge request reports