Skip to content

kcm/region_language: Support implicit LANGUAGE env var, and improve supported language check

Joshua Goins requested to merge work/redstrate/support-language-variable into master

This setting has the same meaning in the kcfg, so we might as well read it from the environment variable like we're already doing with LANG. And for some reason, we are loading it from env vars on the C++ side, while also doing it through KConfig - so let's rip out the C++ code that isn't tested and probably doesn't work.

Tested locally, I set:

  • LANG to en_US.UTF-8
  • LANGUAGE to en_AU:en_GB:en

And starting the KCM shows them by default now, instead of just American English (without a locale configuration):

image

However, it's still possible to add/remove them explicitly - this just affects how they are implicitly loaded in the KCM. Don't mind the "The language is unsupported error" - that will be fixed in another MR :-)

And the implicit language check still works too. I haven't scoured to see if there's a BUG already for this, please let me know.

@arrowdodger

Merge request reports