kcms/users: fix dialog sizing
Reason for the change
The dialogs are currently sized improperly at most window sizes, the result of multiple subtle bugs. This commit fixes them all:
- Span whole overlay in multi-column view, not just the current column
- Give the crop sheet a minimum size compatible with PlaMo and small windows widths
- Use actual metrics to determine the number of columns, not an incorrect approximation
- Allow the picture chooser dialog to become larger when there's space
This code needs a broader refactor, but I wanted to keep this diff here small for backporting.
Test plan
-
kcmshell6 kcm_users
> click on avatar image in the right-most column - Resize the window in various ways
- Click "Open" and choose an image
- Resize the window in various ways again
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
before | after |
(Any non-window-resizing-related window glitches in the videos are recording artifacts, not seen in real life)
Bugs fixed
BUG: 481316 FIXED-IN: 6.3.0