Skip to content

desktopnotifier: listen trash state changes from trashrc

Méven Car requested to merge work/meven/trash-desktop into master

Original commit message(s)

  • desktopnotifier: listen trash state changes from trashrc

Currently the trash state is updated when the files in Trash/files are changed. Except the trashrc file that influences KFileItem::iconFromDesktopFile https://invent.kde.org/frameworks/kio/-/blob/master/src/core/kfileitem.cpp#L1124 called from KFileItem::iconName used to update the trash icon, is updated in TrashImpl::fileRemoved (https://invent.kde.org/frameworks/kio/-/blob/master/src/kioworkers/trash/trashimpl.cpp#L855) after the Trash/files are removed and desktop notifier refreshes the trash icons.

Align the state change check with the trashrc file change, to avoid state race-condition.

Bugs fixed

Could not find a specific bug reported, but I suspect there is some.

https://discuss.kde.org/t/ive-figured-out-the-plasma-5-wastebin-icon-bug-pattern/28762 Gave me a way to reproduce it, more reliably.

Edited by Méven Car

Merge request reports