Skip to content

kcms/colors: use native accent color picker

Reason for the change

kcm_colors currently uses the QtDialogs color picker, which looks somewhat out of place in Plasma - the buttons don't look the same, it does not have the same features as our regular color picker does, etc. Our regular color picker is available through Qt.labs.platform from QML, and we already use that in a couple of places, such as the sensor color assignment in libksysguard.

Test plan

  1. Open kcm_colors
  2. Click the color picker button
  3. (without) Upstream Qt color picker (with) KDE color picker

Screenshots or screen recordings

Before After
color_picker_before color_picker_after

Bugs fixed

Still needs to be actually tested, but it might fix bug 486907 [ETA] Turns out X11 doesn't actually work here anymore and just crashes my computer completely... probably need to install some extra packages in Fedora. Would be great if someone with a working setup could test it.

Edited by Christoph Wolk

Merge request reports

Loading