Skip to content

applets/systray: improve tab navigation in hiddenItemsView

Christoph Wolk requested to merge cwo/plasma-workspace:systray_hiddenitems_focus into master

Reason for the change

Tab navigation in the hidden items popup sort of works, but suffers from two major flaws: the focused item is not actually highlighted, and on most entries there are additional pointless tab stops. This is very confusing. The major cause is the several nested focusscopes with activeFocusOnTab; any attempt to make it work more reasonably is frustrating and extremely fragile.

Instead, we just drop activeFocusOnTab (only) while things are in the hidden items popup, and make tab navigation through the items work by changing the view's currentIndex. This is simple, robust, and works well with screen readers.

Test plan

  1. Click the "Hidden items" expander button in the systray
  2. Press Tab a couple of times
  3. (without) it's bad (with) it's ok

Screenshots or screen recordings

On request

Bugs fixed

N/A but CCBUG: 500705

Merge request reports