Skip to content

kcms/wallpaper: set fewer unused configuration properties

Christoph Wolk requested to merge cwo/plasma-workspace:wallpaper_config_load into master

Reason for the change

  • kcms/wallpaper: set fewer unused configuration properties

When a wallpaper plugin is loaded, the kcm sets three general properties as well as all of the plugins own configuration keys as initial qml properties. However, many wallpaper plugins do not make use of these properties, e.g. because they do not support separate outputs per screen or do not highlight non-default values, and therefore do not have the properties set up, causing errors on loading.

Instead, set them after loading the plugin qml (but before connecting the configuration change signals) where easily possible.

Similar to plasma-desktop!2906 (merged)

Test plan

  1. Open Wallpaper KCM
  2. Switch to a wallpaper other than "Image" or "Slideshow"
  3. (without) lots of warnings (with) fewer warnings

Screenshots or screen recordings

N/A

Bugs fixed

N/A

KScreenLocker and ContainmentConfigAppearance need the same treatment, but I'm waiting for some open MRs for that. (We should maybe centralize the code some day instead of keeping the same thing three+ times)

The configDialog and wallpaperConfiguration still cause error messages, but these will need a bit more thinking and work on the plugin side, as Image/Slideshow expect them to be there while loading.

Edited by Méven Car

Merge request reports