kcms/cursortheme: Use cursor hotspot for preview cursor
- kcms/cursortheme: Use cursor hotspot for preview cursor
Ensures the cursor is rendered at precisely the location it would have when acutally used.
Also, clean up the code by using CursorImage everywhere which carries the hotspot, wrapped in an optional, if needed.
Also, the autocrop has been removed. It is not clear why this would be needed, presumably because the hotspot wasn't used and the cursor would be closer to its hotspot when cropped. It also made the preview image grid a bit fidgety.
Reason for the change
The oxygen busy indicators wobbled around when I hovered them.
Test plan
Moved my cursor around the grid, it felt a lot nicer now, and the Oxygen busy cursor no longer wobbles. By removing autocrop, the preview images are also more evenly spaced out now, for some of them, at least.
Sometimes moving around doesn’t update the cursor, though, until moving to another one. Not sure why that is but that is also pre-existing.
Before (no video though, more showcasing the autocrop removal):
After:
(Wonder if we should increase the grid delegate size or reduce padding or something so the last one isn’t cropped so awkwardly)