ShellCorona: Remove The invariant timer as is not deterministic enough
Looking at bug 468430 and at sentry issues https://crash-reports.kde.org/organizations/kde/issues/267303?project=9 https://crash-reports.kde.org/organizations/kde/issues/401445/?project=9
It seems that sometimes it can happen that the invariants after a screen remove can be executed by the timer before handleOutputOrderChanged.
when this happens, it causes the same backtrace as the issues.
Now, the assumption is that every single time that a screen is added or removed, an output order change will happen eventually, so we check for the screen data integrity only after handleOutputOrderChanged, where we're guaranteed we are in a settled state.
If this doesn't, that would be a bug of KSCreen or KWin.
Adds a test that checks the internal state of shellcorona inbetween an screen removal and an output order change.
(cherry picked from commit 54a9dba9)
d6b6bf2c tests and debug to figure out the bug c6e4ffcb ShellCorona: Remove The invariant timer as is not deterministic enough
Co-authored-by: Marco Martin notmart@gmail.com