libnotificationmanager: Show Power Management notifications by default in Do not Disturb mode

Jan Bidlerrequested to merge
miepee/plasma-workspace:power-management-dnd into master

Original commit message(s)

  • Show Power Management notifications by default in Do not Disturb mode

Reason for the change

I got a game session interrupted because my controller's battery suddenly died, which I found strange, since I knew plasma usually warned for those. Then noticed that the notifications have been thrown and were just hidden due to DnD.

I'm unsure whether more categories should get the treatment too. From the quick glance at the other System Services provided:

  • "Low Disk Space", "Linux Kernel" and "KWin Window Manager" sound similarly urgent enough (although if the latter two appear, there's probably a high chance of the user being kicked out of DnD already)
  • "KDE Portal Integration" sounds similar to spectacle's "show upon explicit user interaction"
  • I'm too unfamiliar about accessibility to have any proper judgement there.

Dunno how much discussion there will be around those. I only did the one case that I actively encountered in this MR to be safe, but if there's a consensus for any others, I'm fine including them here too (or a seperate MR too if that's preferred)

Test plan

Only did this small quick edit via web ui so haven't tested anything. Not even sure if the application name here is correct, or if its powerdevil, org.kde.Solid.PowerManagement or something else entirely (more precisely, how to even find out the correct name in general for an application/service). If it did work though, then the power management notification settings should look like this:
image

Merge request reports