Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 18
    • Issues 18
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 94
    • Merge requests 94
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Workspace
  • Merge requests
  • !982

Open
Created Jul 26, 2021 by Tatsuyuki Ishi@ishitatsuyuki
  • Report abuse
Report abuse

ShellCorona: Activate launcher menu even when no global shortcut is set

  • Overview 3
  • Commits 1
  • Changes 1

activateLauncherMenu is invoked by the hard-coded "Meta" shortcut in KWin. The activation key is not configurable and therefore does not make sense to have different behaviors depending on whether a shortcut is configured for the application menu or not.

Or to say it in a easy way: I don't want to bind Meta+Shift+Alt+Space to the application menu so that Meta opens start menu. It makes no sense.

This patch fixes cases like [1].

In 267b6a8d introduced the activation helper alongside with this check, so it appears to be the intended behavior. But per the reasoning above, I consider this to be a review oversight.

[1] https://old.reddit.com/r/kde/comments/9rc6vh/super_key_stopped_working/

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: meta-shortcut-always