Commit 02c89d74 authored by Nate Graham's avatar Nate Graham 💤
Browse files

[applets/digital-clock] Fix truncated Long Date display in a vertical panel

Summary:
BUG: 381551
FIXED-IN: 5.18.0

Test Plan:
Before: {F7851382, size=full}

After: {F7851383, size=full}

Texted extensively because this code is so brittle. No regressions with long date in a
thick or normal-sized horizontal panel or short date in a thick or normal-sized
horizontal or vertical panel.

The one issue I could find is that sometimes switching between short and long date
formats in a double-thickness vertical panel causes the long date  to be truncated again
until plasmashell is restarted. I was unable to determine why. Assistance would be
appreciated if this is a blocker.

Reviewers: #plasma, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26312
parent 3c1a34a2
......@@ -301,13 +301,13 @@ Item {
PropertyChanges {
target: dateLabel
// this can be marginal bigger than contentHeight because of the horizontal fit
height: sizehelper.contentHeight
height: dateLabel.paintedHeight
width: main.width
fontSizeMode: Text.Fit
minimumPixelSize: Math.min(0.7 * theme.smallestFont.pixelSize, timeLabel.height)
elide: Text.ElideRight
wrapMode: Text.WordWrap
}
AnchorChanges {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment