Commit 14907507 authored by Niccolò Venerandi's avatar Niccolò Venerandi Committed by Niccolò Venerandi

Changed leftMargins to smallSpacing to be consistent

Summary: With other two patches, this aims to make leftMargin consistent in widgets (See https://phabricator.kde.org/D26945 and https://phabricator.kde.org/D26944)

Test Plan:
System tray

Before:
{F7977382}
After:
{F7977379}

Notifications

Before:
{F7977359}
After:
{F7977357}

Battery monitor

Before:
{F7977362}
After:
{F7977361}

Self reminder: networkmanager is still slightly badly aligned

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: gvgeo, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26946
parent 0775faf2
......@@ -41,8 +41,8 @@ FocusScope {
Column {
id: settingsColumn
anchors.horizontalCenter: parent.horizontalCenter
width: parent.width - units.gridUnit
spacing: Math.round(units.gridUnit / 2)
width: parent.width - units.smallSpacing * 2
spacing: units.gridUnit
Components.Label {
// this is just for metrics, TODO use TextMetrics in 5.4 instead
......@@ -107,16 +107,17 @@ FocusScope {
anchors {
horizontalCenter: parent.horizontalCenter
top: settingsColumn.bottom
topMargin: units.gridUnit // not divided by 2 for unified looks
topMargin: units.gridUnit
leftMargin: units.smallSpacing
bottom: dialog.bottom
}
width: parent.width - units.gridUnit
width: parent.width - units.smallSpacing * 2
ListView {
id: batteryList
boundsBehavior: Flickable.StopAtBounds
spacing: Math.round(units.gridUnit / 2)
spacing: Math.round(units.smallSpacing / 2)
KeyNavigation.tab: brightnessSlider
KeyNavigation.backtab: pmSwitch
......
......@@ -70,6 +70,7 @@ ColumnLayout{
id: header
visible: !Kirigami.Settings.isMobile
Layout.fillWidth: true
Layout.leftMargin: units.smallSpacing
spacing: 0
RowLayout {
......@@ -278,6 +279,7 @@ ColumnLayout{
Layout.fillHeight: true
Layout.preferredWidth: units.gridUnit * 18
Layout.preferredHeight: units.gridUnit * 24
Layout.leftMargin: units.smallSpacing
ListView {
id: list
......
......@@ -57,7 +57,7 @@ ColumnLayout {
//applet open, no sidebar
} else {
return 0;
return units.smallSpacing;
}
}
Layout.rightMargin: {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment