Commit 3a44e360 authored by Nate Graham's avatar Nate Graham 🔩

Make Pin buttons consistently sized in System Tray and Clock pop-ups

The Pin buttons in the System Tray and Clock pop-ups are very small. This has
always felt slightly odd to me, and the recent change to add a defined header
area for the System Tray pop-up makes it even odder in my opinion, as the icon
is now much smaller than the area it visibly inhabits. This patch makes both icons
in both applets use the standard size with no local overrides. The clock pop-up's
pin button is ported to PC3 in the process.

Depends on D28228

Test Plan:
Before: {F8194101}
After: {F8194100}

Reviewers: #vdg, #plasma, ognarb, mart

Reviewed By: #vdg, #plasma, ognarb, mart

Subscribers: mart, ndavis, broulik, ognarb, plasma-devel

Tags: #plasma

Maniphest Tasks: T10470

Differential Revision:
parent e5caa59a
......@@ -20,6 +20,7 @@ import QtQuick.Layouts 1.1
import org.kde.plasma.core 2.0 as PlasmaCore
import org.kde.plasma.calendar 2.0 as PlasmaCalendar
import org.kde.plasma.components 2.0 as PlasmaComponents
import org.kde.plasma.components 3.0 as PlasmaComponents3
import org.kde.plasma.extras 2.0 as PlasmaExtras
Item {
......@@ -469,14 +470,14 @@ Item {
// Allows the user to keep the calendar open for reference
PlasmaComponents.ToolButton {
PlasmaComponents3.ToolButton {
anchors.right: parent.right
width: Math.round(units.gridUnit * 1.25)
height: width
checkable: true
iconSource: "window-pin"
onCheckedChanged: = checked
tooltip: i18n("Keep Open")
onToggled: = checked "window-pin"
PlasmaComponents3.ToolTip {
text: i18n("Keep Open")
......@@ -101,8 +101,6 @@ ColumnLayout {
PlasmaComponents.ToolButton {
id: pinButton
implicitHeight: Math.round(units.gridUnit * 1.25)
implicitWidth: implicitHeight
checkable: true
onToggled: = checked
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment