Members of the KDE Community are recommended to subscribe to the kde-community mailing list at to allow them to participate in important discussions and receive other important announcements

Commit 4c2eb556 authored by Marco Martin's avatar Marco Martin

create shell surface only at the right moment

make the behavior similar to Dialog
create a plasmashell surface only when isVisible() as
some expose events can arrive there too, and also not
create the shell surface if the exposed surface is null

Test Plan: krunner seems to be more reliable

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision:
parent 415b6d81
......@@ -230,7 +230,13 @@ bool View::event(QEvent *event)
if (m_plasmaShell && event->type() == QEvent::Expose) {
using namespace KWayland::Client;
if (!m_plasmaShellSurface) {
auto ee = static_cast<QExposeEvent*>(event);
if (ee->region().isNull()) {
return retval;
if (!m_plasmaShellSurface && isVisible()) {
Surface *s = Surface::fromWindow(this);
if (!s) {
return retval;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment