Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit 74fe83cb authored by David Edmundson's avatar David Edmundson

Show alternatives dialog immediately

Summary:
There is (a very appreciated) a description of why loading the
alternatives dialog was queued.

This causes issues for autohide as it gives us a time when the menu is
closed and we don't have anything else inhibiting autohide.

The comment doesn't seem to hold true with the latest frameworks which has
some mouse releasing code on the menu itself.

Test Plan: Clicked a lot. Clicks worked first time.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6647
parent e9401081
......@@ -1311,13 +1311,8 @@ void ShellCorona::handleContainmentAdded(Plasma::Containment *c)
{
connect(c, &Plasma::Containment::showAddWidgetsInterface,
this, &ShellCorona::toggleWidgetExplorer);
// Why queued? this is usually triggered after a context menu closes
// due to its sync,modal nature it may eat some mouse event from the scene
// waiting a bit to create a new window, the dialog seems to reliably
// avoid the eating of one click in the panel after the context menu is gone
connect(c, &Plasma::Containment::appletAlternativesRequested,
this, &ShellCorona::showAlternativesForApplet, Qt::QueuedConnection);
this, &ShellCorona::showAlternativesForApplet);
connect(c, &Plasma::Containment::appletCreated, this, [this, c] (Plasma::Applet *applet) {
executeSetupPlasmoidScript(c, applet);
});
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment