Commit 7df184af authored by Wolfgang Bauer's avatar Wolfgang Bauer

[xembedsniproxy] Fix check whether to use XTest

Because of C++'s operator precedence, '!' logically negated
all_event_masks only instead of the whole expression.
This resulted in the condition always being false and XTest never being

Adding a pair of brackets fixes it.

BUG: 362941
BUG: 375017
FIXED-IN: 5.10.1
Differential Revision:
parent 3d506f00
......@@ -209,7 +209,7 @@ SNIProxy::SNIProxy(xcb_window_t wid, QObject* parent):
//if the client does supports that we send directly, otherwise we'll use xtest
auto waCookie = xcb_get_window_attributes(c, wid);
auto windowAttributes = xcb_get_window_attributes_reply(c, waCookie, nullptr);
if (! windowAttributes->all_event_masks & XCB_EVENT_MASK_BUTTON_PRESS) {
if (! (windowAttributes->all_event_masks & XCB_EVENT_MASK_BUTTON_PRESS)) {
m_injectMode = XTest;
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment