Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit 9e90fdd2 authored by Stefan Brüns's avatar Stefan Brüns

[Bookmarks Runner] Avoid leaking FetchSqlite instances

Summary:
The favicon and places instances are created in the prepare() call,
leaking the instance from the last invocation. Delete the old
instance in teardown().

See also T9626.

Test Plan:
run several queries in krunner
-> instances are no longer leaked

Reviewers: #frameworks, mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16410
parent 145caeac
......@@ -149,9 +149,13 @@ void Firefox::teardown()
{
if(m_fetchsqlite) {
m_fetchsqlite->teardown();
delete m_fetchsqlite;
m_fetchsqlite = nullptr;
}
if(m_fetchsqlite_fav) {
m_fetchsqlite_fav->teardown();
delete m_fetchsqlite_fav;
m_fetchsqlite_fav = nullptr;
delete m_favicon;
m_favicon = nullptr;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment