Commit a8299642 authored by David Edmundson's avatar David Edmundson

Block calls to org.kde.KSplash till it is registered

Summary:
A recent update to startup made it too fast and hit a race with ksplash.

We expose that we could send that kinit and ksmserver were ready before
ksplash registered the service name.

We have an existing mechanism to make DBus server queue up messages if a
service is not registered yet without actually activating it. So we can
re-use that.

Long term we need to rethink ksplash completely.

Test Plan:
Confirmed issue with extra debug
Logged in and the issue was gone

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27702
parent 22a99ad1
......@@ -16,7 +16,13 @@ target_link_libraries(plasma_waitforname
configure_file(org.kde.plasma.Notifications.service.in
${CMAKE_CURRENT_BINARY_DIR}/org.kde.plasma.Notifications.service)
configure_file(org.kde.KSplash.service.in
${CMAKE_CURRENT_BINARY_DIR}/org.kde.KSplash.service)
install(TARGETS plasma_waitforname ${KDE_INSTALL_TARGETS_DEFAULT_ARGS})
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/org.kde.plasma.Notifications.service
DESTINATION ${KDE_INSTALL_DBUSSERVICEDIR})
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/org.kde.KSplash.service
DESTINATION ${KDE_INSTALL_DBUSSERVICEDIR})
[D-BUS Service]
Name=org.kde.KSplash
Exec=@KDE_INSTALL_FULL_BINDIR@/plasma_waitforname org.kde.KSplash
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment