Commit b49d5cfd authored by Kai Uwe Broulik's avatar Kai Uwe Broulik 🍇
Browse files

Only serialize window pixmap if we're using it

The previous QIcon::name() check wasn't sufficient as it only works with theme icon names (e.g. kate)
but not icons created from an absolute path, e.g. /some/special/icon/location/kate.png.
The latter is usually the case for containerized apps which have a proper application desktop file
installed but their icon in some path within the application image or some container daemon location.
Since we already store the information for whether we had to fall back to using the actual window pixmap,
check for this before trying to serialize icon pixmap data.

Differential Revision:
parent a51ecd9d
......@@ -535,17 +535,25 @@ QUrl XWindowTasksModel::Private::launcherUrl(WId window, bool encodeFallbackIcon
const AppData &data = appData(window);
if (!encodeFallbackIcon || ! {
return data.url;
QUrl url = data.url;
if (!encodeFallbackIcon || ! {
return url;
// Forego adding the window icon pixmap if the URL is otherwise empty.
if (!url.isValid()) {
return QUrl();
// Only serialize pixmap data if the window pixmap is actually being used.
// QIcon::name() used above only returns a themed icon name but nothing when
// the icon was created using an absolute path, as can be the case with, e.g.
// containerized apps.
if (!usingFallbackIcon.contains(window)) {
return url;
const QPixmap pixmap = KWindowSystem::icon(window, KIconLoader::SizeLarge, KIconLoader::SizeLarge, false);
if (pixmap.isNull()) {
return data.url;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment