Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Plasma Workspace
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
3
Issues
3
List
Boards
Labels
Service Desk
Milestones
Merge Requests
62
Merge Requests
62
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Plasma
Plasma Workspace
Commits
bfac9ca9
Commit
bfac9ca9
authored
Jan 03, 2018
by
Friedrich W. H. Kossebau
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[weather] Do not abuse #warning for normal FIXME notes
parent
32932b44
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
6 deletions
+4
-6
dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
+4
-6
No files found.
dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
View file @
bfac9ca9
...
...
@@ -626,9 +626,8 @@ void UKMETIon::parseWeatherObservation(const QString& source, WeatherData& data,
}
else
if
(
elementName
==
QLatin1String
(
"description"
))
{
QString
observeString
=
xml
.
readElementText
();
const
QStringList
observeData
=
observeString
.
split
(
QLatin1Char
(
':'
));
#ifdef __GNUC__
#warning FIXME: We should make this use a QRegExp but I need some help here :) -spstarr
#endif
// FIXME: We should make this use a QRegExp but I need some help here :) -spstarr
QString
temperature_C
=
observeData
[
1
].
section
(
QChar
(
176
),
0
,
0
).
trimmed
();
parseFloat
(
data
.
temperature_C
,
temperature_C
);
...
...
@@ -748,9 +747,8 @@ void UKMETIon::parseFiveDayForecast(const QString& source, QXmlStreamReader& xml
xml
.
readNext
();
if
(
xml
.
name
()
==
QLatin1String
(
"title"
))
{
line
=
xml
.
readElementText
().
trimmed
();
#ifdef __GNUC__
#warning FIXME: We should make this all use QRegExps in UKMETIon::parseFiveDayForecast() for forecast -spstarr
#endif
// FIXME: We should make this all use QRegExps in UKMETIon::parseFiveDayForecast() for forecast -spstarr
const
QString
p
=
line
.
section
(
QLatin1Char
(
','
),
0
,
0
);
period
=
p
.
section
(
QLatin1Char
(
':'
),
0
,
0
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment