Commit c12befa1 authored by Nate Graham's avatar Nate Graham 💤
Browse files

Add `sudo` to the lines in install-sessions.sh that need it so you don't need...

Add `sudo` to the lines in install-sessions.sh that need it so you don't need to sudo the whole thing

Summary:
Because this script copies things to /, it needs to be run with `sudo`. But two of the
copy operations also copy things to your home directory, and if you `sudo` the whole
script, this results in those files being copied with root ownership, which can cause
problems later.

This patch prepends `sudo` to just the copy operations that need it so that the ones
that don't aren't run with inappropriately elevated permissions.

Test Plan:
- Run `~/kde/build/plasma-workspace/login-sessions/install-sessions.sh`
- Get prompted for the root password
- Enter it
- See that `plasma-dev-prefix.sh` and `startplasma-dev.sh` in `~/kde/usr/lib64/libexec/` have user ownership, not root ownership

Reviewers: apol, #plasma

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24677
parent 7f0ce07b
#!/bin/sh
set -e
install @CMAKE_CURRENT_BINARY_DIR@/plasmax11-dev.desktop /usr/share/xsessions/
install @CMAKE_CURRENT_BINARY_DIR@/plasmawayland-dev.desktop /usr/share/wayland-sessions/
sudo install @CMAKE_CURRENT_BINARY_DIR@/plasmax11-dev.desktop /usr/share/xsessions/
sudo install @CMAKE_CURRENT_BINARY_DIR@/plasmawayland-dev.desktop /usr/share/wayland-sessions/
install @CMAKE_BINARY_DIR@/prefix.sh @CMAKE_INSTALL_FULL_LIBEXECDIR@/plasma-dev-prefix.sh
install @CMAKE_CURRENT_BINARY_DIR@/startplasma-dev.sh @CMAKE_INSTALL_FULL_LIBEXECDIR@
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment