Commit c96a9f5a authored by David Edmundson's avatar David Edmundson

Remove pointless setMin/setMax size on DesktopView

Summary:
On X, this is entirely useless.There's a special code path in create for
windowType == Desktop and in ::setGeometry it doesn't seem to help/hinder.
It's not like we need WM_NORMAL_HINTS for a WM to resize us.

On wayland it's downright destructive.
On the second setGeometry call the QPA bounds the new geography to the
current min/max (from our previous screenGeometryChanged). But updating
the min/max doesn't update our geometry. End result is our screen is
off.

Test Plan:
Resized screen on Wayland. Wallpaper now filled exactly instead of being broken
Resized screen on Xcb. Wallpaper still filled the screen precisely

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13850
parent 7ed3fba4
......@@ -306,8 +306,6 @@ void DesktopView::screenGeometryChanged()
const QRect geo = m_screenToFollow->geometry();
// qDebug() << "newGeometry" << this << geo << geometry();
setGeometry(geo);
setMinimumSize(geo.size());
setMaximumSize(geo.size());
if (m_shellSurface) {
m_shellSurface->setPosition(geo.topLeft());
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment