Commit fa74ee53 authored by Kai Uwe Broulik's avatar Kai Uwe Broulik 🍇

[Notifications] Don't alter top margin of ThumbnailStrip

This edge touches the notification text and as such shouldn't "bleed in" as with the other edges that touch the dialog borders.
Previously this wasn't an issue as there was a bug causing excess bottom padding on the dialog.

Differential Revision: https://phabricator.kde.org/D21569
parent 21d8bf8b
......@@ -317,7 +317,8 @@ ColumnLayout {
id: thumbnailStripLoader
Layout.leftMargin: notificationItem.thumbnailLeftPadding
Layout.rightMargin: notificationItem.thumbnailRightPadding
Layout.topMargin: notificationItem.thumbnailTopPadding
// no change in Layout.topMargin to keep spacing to notification text consistent
Layout.topMargin: 0
Layout.bottomMargin: notificationItem.thumbnailBottomPadding
Layout.fillWidth: true
active: notificationItem.urls.length > 0
......@@ -325,7 +326,7 @@ ColumnLayout {
sourceComponent: ThumbnailStrip {
leftPadding: -thumbnailStripLoader.Layout.leftMargin
rightPadding: -thumbnailStripLoader.Layout.rightMargin
topPadding: -thumbnailStripLoader.Layout.topMargin
topPadding: -notificationItem.thumbnailTopPadding
bottomPadding: -thumbnailStripLoader.Layout.bottomMargin
urls: notificationItem.urls
onOpenUrl: notificationItem.openUrl(url)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment