Commit ca30506c authored by Laurent Montel's avatar Laurent Montel
Browse files

Use SYSTEMD_USER_UNIT_INSTALL_DIR

parent 9cfb012e
Pipeline #123469 passed with stage
in 54 seconds
......@@ -85,7 +85,7 @@ install(TARGETS polkit-kde-authentication-agent-1 DESTINATION ${KDE_INSTALL_LIBE
install(FILES ${CMAKE_BINARY_DIR}/polkit-kde-authentication-agent-1.desktop DESTINATION ${KDE_INSTALL_AUTOSTARTDIR})
install(FILES ${CMAKE_BINARY_DIR}/polkit-kde-authentication-agent-1.desktop DESTINATION ${KDE_INSTALL_APPDIR} RENAME org.kde.polkit-kde-authentication-agent-1.desktop)
ecm_install_configured_files(INPUT plasma-polkit-agent.service.in DESTINATION ${KDE_INSTALL_SYSTEMDUSERUNITDIR})
ecm_install_configured_files(INPUT plasma-polkit-agent.service.in DESTINATION ${SYSTEMD_USER_UNIT_INSTALL_DIR})
install(FILES policykit1-kde.notifyrc DESTINATION ${KDE_INSTALL_KNOTIFY5RCDIR})
......
  • @mlaurent Why the switch to the old unprefixed (and deprecated) variable here?

  • Oops indeed I made an error I read "SYSTEMDUSERUNITDIR Systemd User Units (lib/systemd/user) [SYSTEMD_USER_UNIT_INSTALL_DIR]. Since 5.65 " for me it was the last version of variable.

    Perhaps we need to make it as deprecated.

  • mentioned in commit 4294f03c

    Toggle commit list
  • I would not know a way to mark cmake variables as deprecated, so putting things into the docs is all we might be able to. Currently there is a general comment at the top of the list of vars in the docs, saying

    default values in parentheses and alternative, deprecated variable name in square brackets)

    Repeating a "deprecated:" text in all places might be too much noise, also will blow up the layout in some places.

    Any ideas how to improve things surely welcome.

  • Though it is strange that at 5.65, when the unprefixed ones were already deprecated, this new one was added. No idea why, in any case, gone in KDEInstallDirs6.

Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment