Polkit KDE Agent merge requestshttps://invent.kde.org/plasma/polkit-kde-agent-1/-/merge_requests2023-04-28T14:07:09Zhttps://invent.kde.org/plasma/polkit-kde-agent-1/-/merge_requests/4Rewrite polkit-kde-agent-12023-04-28T14:07:09ZJan BlackquillRewrite polkit-kde-agent-1This completely overhauls polkit-kde-agent-1, using a new codebase built entirely from scratch.
A new, Kirigami-based UI is also here to replace the old QWidgets-based UI.
![maldere](/uploads/98fddc5c02335d88a42e3778b16c62af/maldere.pn...This completely overhauls polkit-kde-agent-1, using a new codebase built entirely from scratch.
A new, Kirigami-based UI is also here to replace the old QWidgets-based UI.
![maldere](/uploads/98fddc5c02335d88a42e3778b16c62af/maldere.png)
test instructions:
- Install as normal
- Kill the old `polkit-kde-authentication-agent-1` process.
- If the new one doesn't automatically restart, restart it, wherever you installed it to. it's in libexec, not bin, so you'll need to use the full path to launch. you can see where it got installed to in the make install output.5.24Jan BlackquillJan Blackquillhttps://invent.kde.org/plasma/polkit-kde-agent-1/-/merge_requests/29Always use "lock" icon in auth dialog, disregarding icon from auth action2023-08-30T21:12:43ZNate GrahamAlways use "lock" icon in auth dialog, disregarding icon from auth actionIn the past, the old QtWidgets-based auth dialog disregarded the icon
set by auth actions in favor of a hardcoded one. This was presumably
because we wanted to always show an appropriate and consistent icon,
instead of whatever random an...In the past, the old QtWidgets-based auth dialog disregarded the icon
set by auth actions in favor of a hardcoded one. This was presumably
because we wanted to always show an appropriate and consistent icon,
instead of whatever random and inconsistent icon was specified by all
the different auth actions out there.
As a result, we got sloppy about setting icons in our own auth action
files. Many are using the generic/default `kauth-example` icon name
which does not exist in the Breeze theme.
However the new Plasma 6 based dialog does honor the icon in the auth
file. As a result, the dialog shows a lot of broken and inconsistent
icons.
We could fix this by changing the icons in all of our auth files
everywhere. However that has two downsides:
1. It would be a lot of work
2. The result would still most likely result in icon inconsistency, when
all we really want to do is show the same lock-style icon in the
dialog every time
More work for a worse result doesn't strike me as an ideal use of time.
Thus, this commit goes in the other direction and brings back the
approach taken by the old QtWidgets dialog by ignoring the icon set by
auth actions, instead always showing the "lock" icon in the dialog:
![image](/uploads/71ed6e64fc3ac6004ee286b7754d61b0/image.png)
BUG: 473720
@teams/vdg @devinlin @sitter
(VDG folks please only focus on the icon as that's all that's being touched here)6https://invent.kde.org/plasma/polkit-kde-agent-1/-/merge_requests/21Port agent to QML, and add an interface for Plasma Mobile2023-04-28T14:06:22ZDevin LinPort agent to QML, and add an interface for Plasma MobileReplaces https://invent.kde.org/plasma/polkit-kde-agent-1/-/merge_requests/12, https://invent.kde.org/plasma/polkit-kde-agent-1/-/merge_requests/4
Based on mockups from: https://phabricator.kde.org/T8569
Will fix: https://invent.kde.or...Replaces https://invent.kde.org/plasma/polkit-kde-agent-1/-/merge_requests/12, https://invent.kde.org/plasma/polkit-kde-agent-1/-/merge_requests/4
Based on mockups from: https://phabricator.kde.org/T8569
Will fix: https://invent.kde.org/teams/plasma-mobile/issues/-/issues/106
![image](/uploads/9ebda04d4dcc3f0e3981517f188c9e80/image.png)
![image](/uploads/ddfb8af85be681ebbd4660a39c75d740/image.png)
OLD:
![image](/uploads/b4db4cff3f97302f3b67d2ef2463412c/image.png)6https://invent.kde.org/plasma/polkit-kde-agent-1/-/merge_requests/1use pretty global notification name and title capitalization2020-07-23T15:50:25ZHarald Sitteruse pretty global notification name and title capitalizationthe KCM preferes Name and uses it as title so set a pretty name and
capitalize the Names correctlythe KCM preferes Name and uses it as title so set a pretty name and
capitalize the Names correctly