Commit d1d9ed7d authored by Kai Uwe Broulik's avatar Kai Uwe Broulik 🍇
Browse files

Update battery notifications if they remain open

They are critical and persistent nowadays, so make sure the percentage
is updated live to match the current percentage if it is left open
for a prolonged period of time.
parent f21df3e3
......@@ -620,6 +620,9 @@ bool Core::emitBatteryChargePercentNotification(int currentPercent, int previous
return false;
// Make sure a notificaton that's kept open updates its percentage live.
if (m_backend->acAdapterState() == BackendInterface::Plugged
&& !flags.testFlag(ChargeNotificationFlag::NotifyWhenAcPluggedIn)) {
return false;
......@@ -645,7 +648,7 @@ void Core::handleLowBattery(int percent)
m_lowBatteryNotification = new KNotification(QStringLiteral("lowbattery"), KNotification::Persistent, nullptr);
m_lowBatteryNotification->setTitle(i18n("Battery Low (%1% Remaining)", percent));
updateBatteryNotifications(percent); // sets title
m_lowBatteryNotification->setText(i18n("Battery running low - to continue using your computer, plug it in or shut it down and change the battery."));
......@@ -660,7 +663,7 @@ void Core::handleCriticalBattery(int percent)
// no parent, but it won't leak, since it will be closed both in case of timeout or direct action
m_criticalBatteryNotification = new KNotification(QStringLiteral("criticalbattery"), KNotification::Persistent, nullptr);
m_criticalBatteryNotification->setTitle(i18n("Battery Critical (%1% Remaining)", percent));
updateBatteryNotifications(percent); // sets title
const QStringList actions = {i18nc("Cancel timeout that will automatically put system to sleep because of low battery", "Cancel")};
......@@ -694,6 +697,17 @@ void Core::handleCriticalBattery(int percent)
void Core::updateBatteryNotifications(int percent)
if (m_lowBatteryNotification) {
m_lowBatteryNotification->setTitle(i18n("Battery Low (%1% Remaining)", percent));
if (m_criticalBatteryNotification) {
m_criticalBatteryNotification->setTitle(i18n("Battery Critical (%1% Remaining)", percent));
void Core::onAcAdapterStateChanged(PowerDevil::BackendInterface::AcAdapterState state)
......@@ -132,6 +132,7 @@ private:
void unregisterActionTimeouts(Action *action);
void handleLowBattery(int percent);
void handleCriticalBattery(int percent);
void updateBatteryNotifications(int percent);
void readChargeThreshold();
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment