Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • PowerDevil PowerDevil
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • PowerDevilPowerDevil
  • Merge requests
  • !75

powerprofileconfig: Use m_profileCombo as the watcher's parent

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Fushan Wen requested to merge work/fusionfuture/BUG443858-powerdevil-crash-icon-view into master Dec 21, 2021
  • Overview 7
  • Commits 1
  • Pipelines 12
  • Changes 1

m_profileCombo could be an invalid pointer, because when clicking an item, QAbstractItemView::clicked and QAbstractItemView::activated in systemsettings both will be emitted, and IconMode::changeModule will be called twice, and closeModules() will free m_profileCombo in the second call, which will crash systemsettings.

To fix the crash, set the watcher's parent to m_profileCombo, so when m_profileCombo is destroyed, the watcher is also destroyed and the connection is disconnected to prevent modification to the old m_profileCombo.

CCBUG: 443858

Edited Dec 23, 2021 by Fushan Wen
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/fusionfuture/BUG443858-powerdevil-crash-icon-view