Skip to content

libkcups: Remove usage of KCupsRequest::waitTillFinished from models

Mike Noe requested to merge work/noee/more-remove-waittilfinished into master

Remove waitTillFinished pattern where QML (KCM/Plasmoid) might use model (Job/Printer) apis to manage print jobs/queues.

Add a request helper to provide error notification, a finished callback, and handle the request delete.

Also, for the Request, instead of at instantiation, only connect Finshed->eventloop::quit when waitTillFinished is called.

One instance is remaining in JobModel (DnD), but there are currently no QML components in print-manager that use that feature.

Related: #16 (closed)

Testing

Pausing/Resuming print queues from the plasmoid/kcm should work as expected. Cancel/hold jobs from the plasmoid as well as the Print Queue app should work as expected.

Edited by Mike Noe

Merge request reports