GitLab

GIT_SILENT

GIT_SILENT

Summary:
Align wallpaper dialog button to bottom instead of vertically centering it between the theme info and the bottom of the frame.

BUG: 418173
FIXED-IN: 5.18.3

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27667

GIT_SILENT

GIT_SILENT

Summary:
If we are creating a config file and its directory doesn't exist, we fail to set the right permissions for the file.

This affects kde_settings.conf and results in the KCM not being able to read stored settings.

BUG: 414396
CC-BUG: 342722
FIXED-IN: 5.18.1

Test Plan:
rm-rf sddm.conf.d
save settings in the kcm in various ways
kde_settings.conf is now world readable agian

Reviewers: davidedmundson

Subscribers: plasma-devel, ngraham

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27388

Summary:
We have 3 vertical spacers in the Advanced tab and they're defined as Expanding.

So that means they become quite the gaps if the window is expanded.

This patch changes their size policy to Preferred to avoid such a feature.

BUG: 417657
FIXED-IN: 5.18.1

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27418

Summary:
For historical reasons some .desktop files in wayland-sessions suffix
their .desktop files, some expect the display manager to do it.

SDDM compares the suffix and only adds if needed. Our config UI should
match exactly.

The obvious comment is this only works in English, but for some reason
both SDDM and this code only read the Name entry in English anyway.

BUG: 417499

Test Plan: Opened KCM

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27358

Summary:
Suggested for D26813. Prerequiste if user-manager is to not send any SDDM config file path on its own.

The config file paths are now defined in the authhelper as opposed to being sent in a variant map from the main kcm file.

I also edited paths in that main file because they were wrong.

This does not yet solve bug 414396.

CC-BUG: 342722

Test Plan: Testing with D26813 I managed to write to the config file without user-manager defining the path.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27142

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
The text that shows up as the theme preview when no image preview is available was always just black.

That's not great for dark themes so this patch makes it use text color.

Test Plan:
Before:
{F7817076}

After:
{F7817077}

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25971

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
The old readme file was just 4 outdated lines on how to compile the package..

I've now tried to add all the crucial info and write the file in Markdown.

CC-BUG: 414289

Test Plan:
{F7772162}
{F7772163}

Reviewers: #plasma, #vdg, ngraham, davidedmundson

Reviewed By: #plasma, #vdg, ngraham, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25415

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
This allows devs to run: "make clang-format" and format all files easily
using the preset KDE clang format style

This patch adds support so devs can easily test the intended formatting
now, it doesn't change the code yet.

Doing an initial run to commit everything will happen later.

Test Plan:
Ran script
git diff was full of amazingly cleaned code

See D25134

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT

Summary:
QQuickImage::sourceSize is in device pixels for pixmap images.

Converting is the responsibility of the calling code.

BUG: 407689

Test Plan:
QT_SCALE_FACTOR=1.5 kcmshell5 sddm
Looked at image

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24591

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

Summary:
Sddm-kcm should depend on sddm.
Sddm sets up an sddm user which is used to run the greeter.
Therefore it should not be possible to run sddm-kcm without an sddm user existing.

But if it should happen that's the case, this patch adds a check for the sddm user.
If the user is not present, everything will be aborted and an error message will pop-up.

openSUSE BUG:
  - https://bugzilla.opensuse.org/show_bug.cgi?id=1145182
  - https://bugzilla.opensuse.org/show_bug.cgi?id=1146817
  - https://bugzilla.opensuse.org/show_bug.cgi?id=1146831

Test Plan:
changed line `QString sddmHomeDirPath = KUser("sddm").homeDir();` to look up some bogus user
syncing and resetting is aborted, error message pops up

{F7273960}

Reviewers: #plasma, davidedmundson, ngraham, #vdg, fvogt

Reviewed By: ngraham, #vdg

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23378

GIT_SILENT

GIT_SILENT