GitLab

GIT_SILENT

GIT_SILENT

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

- Choose better QString overloads
- Remove unused variables
- Add missing emit keywords
- Avoid multi-arg method call
- Avoid detaching in loop
- Do not show empty error messages, for exmple when the user clicks the
  cancel button

BUG: 407686
FIXED-IN: 5.20

BUG: 416255
FIXED-IN: 5.20

Without deleting the file KNS could not tell if we have the entry manually uninstalled.
Also the config entry gets removed once the uninstallation is successful.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: Make it compile against qt5.15

Reviewers: davidedmundson, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27866

Summary:
Align wallpaper dialog button to bottom instead of vertically centering it between the theme info and the bottom of the frame.

BUG: 418173
FIXED-IN: 5.18.3

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27667

GIT_SILENT

GIT_SILENT

Summary:
If we are creating a config file and its directory doesn't exist, we fail to set the right permissions for the file.

This affects kde_settings.conf and results in the KCM not being able to read stored settings.

BUG: 414396
CC-BUG: 342722
FIXED-IN: 5.18.1

Test Plan:
rm-rf sddm.conf.d
save settings in the kcm in various ways
kde_settings.conf is now world readable agian

Reviewers: davidedmundson

Subscribers: plasma-devel, ngraham

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27388

Summary:
We have 3 vertical spacers in the Advanced tab and they're defined as Expanding.

So that means they become quite the gaps if the window is expanded.

This patch changes their size policy to Preferred to avoid such a feature.

BUG: 417657
FIXED-IN: 5.18.1

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27418

Summary:
For historical reasons some .desktop files in wayland-sessions suffix
their .desktop files, some expect the display manager to do it.

SDDM compares the suffix and only adds if needed. Our config UI should
match exactly.

The obvious comment is this only works in English, but for some reason
both SDDM and this code only read the Name entry in English anyway.

BUG: 417499

Test Plan: Opened KCM

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27358

Summary:
Suggested for D26813. Prerequiste if user-manager is to not send any SDDM config file path on its own.

The config file paths are now defined in the authhelper as opposed to being sent in a variant map from the main kcm file.

I also edited paths in that main file because they were wrong.

This does not yet solve bug 414396.

CC-BUG: 342722

Test Plan: Testing with D26813 I managed to write to the config file without user-manager defining the path.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27142

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"