Commit 0c76098e authored by Laurent Montel's avatar Laurent Montel 😁 Committed by Albert Astals Cid

Fixed issue causing changed signal to be called with false argument

Summary:
 AdvanceConfig::changed signal is called with changed=false arguement when QGroupBox::clicked is called with checked=false causing the Apply button to remain disabled.

BUG: 403366

Test Plan:
1. Open SDDM settings
2. Enable auto-login, save and close.
3. Open SDDM settings again
4. Uncheck auto-login

Apply button should now be enabled.
Same steps for Relogin after quit checkbox.

Reviewers: mlaurent

Reviewed By: mlaurent

Subscribers: mlaurent, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19959

(cherry picked from commit ed3decc0)
parent e987eb43
......@@ -51,8 +51,10 @@ AdvanceConfig::AdvanceConfig(const KSharedConfigPtr &config, QWidget *parent) :
connect(configUi->minimumUid, &QLineEdit::textChanged, this, &AdvanceConfig::slotUidRangeChanged);
connect(configUi->maximumUid, SIGNAL(textChanged(QString)), SIGNAL(changed()));
connect(configUi->maximumUid, &QLineEdit::textChanged, this, &AdvanceConfig::slotUidRangeChanged);
connect(configUi->autoLogin, &QGroupBox::clicked, this, &AdvanceConfig::changed);
connect(configUi->reloginAfterQuit, &QAbstractButton::clicked, this, &AdvanceConfig::changed);
// manually emit changed signal since QGroupBox::clicked will pass false to changed() when unchecked
connect(configUi->autoLogin, &QGroupBox::clicked, this, [this] { emit changed(); });
connect(configUi->reloginAfterQuit, &QAbstractButton::clicked, this, [this] { emit changed(); });
}
AdvanceConfig::~AdvanceConfig()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment