Commit 119ca20d authored by Nicolas Fella's avatar Nicolas Fella
Browse files

Raise minimum CMake version to 3.16

As discussed in https://mail.kde.org/pipermail/plasma-devel/2021-February/119329.html

GIT_SILENT
parent b3770375
cmake_minimum_required(VERSION 3.0) cmake_minimum_required(VERSION 3.16)
set(PROJECT_VERSION "5.21.80") set(PROJECT_VERSION "5.21.80")
......
  • For reasons I do not understand, this commit makes System Settings crash on launch for me, with the following backtrace:

    #0  0x00007f751c059254 in KConfigGroup::sync (this=0x14f4958) at /home/nate/kde/src/kconfig/src/core/kconfiggroup.cpp:599
    #1  0x00007f750c1a5dc4 in SidebarMode::~SidebarMode (this=0x147c940, __in_chrg=<optimized out>) at /home/nate/kde/src/systemsettings/sidebar/SidebarMode.cpp:318
    #2  0x00007f750c1a5e69 in SidebarMode::~SidebarMode (this=0x147c940, __in_chrg=<optimized out>) at /home/nate/kde/src/systemsettings/sidebar/SidebarMode.cpp:320
    #3  0x0000000000419981 in KPluginFactory::create<BaseMode> (args=..., parent=0x1026730, this=0x1465e50) at /home/nate/kde/usr/include/KF5/KCoreAddons/kpluginfactory.h:775
    #4  SettingsBase::initApplication (this=0x1026730) at /home/nate/kde/src/systemsettings/app/SettingsBase.cpp:142
    #5  0x00007f751bc46351 in QObject::event (this=this@entry=0x1026730, e=e@entry=0x1429980) at kernel/qobject.cpp:1314
    #6  0x00007f751c98d269 in QWidget::event (this=this@entry=0x1026730, event=event@entry=0x1429980) at kernel/qwidget.cpp:9080
    #7  0x00007f751ca9a6fc in QMainWindow::event (this=this@entry=0x1026730, event=event@entry=0x1429980) at widgets/qmainwindow.cpp:1341
    #8  0x00007f751e305262 in KMainWindow::event (this=this@entry=0x1026730, ev=ev@entry=0x1429980) at /home/nate/kde/src/kxmlgui/src/kmainwindow.cpp:913
    #9  0x00007f751e331a69 in KXmlGuiWindow::event (this=0x1026730, ev=0x1429980) at /home/nate/kde/src/kxmlgui/src/kxmlguiwindow.cpp:109
    #10 0x00007f751c94d4ff in QApplicationPrivate::notify_helper (this=<optimized out>, receiver=0x1026730, e=0x1429980) at kernel/qapplication.cpp:3632
    #11 0x00007f751bc1a32a in QCoreApplication::notifyInternal2 (receiver=0x1026730, event=0x1429980) at kernel/qcoreapplication.cpp:1063
    #12 0x00007f751bc1cd61 in QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0xe74960) at kernel/qcoreapplication.cpp:1817
    #13 0x00007f751bc72233 in postEventSourceDispatch (s=s@entry=0xf71b80) at kernel/qeventdispatcher_glib.cpp:277
    #14 0x00007f751a0b2f57 in g_main_dispatch (context=0x7f7510005000) at ../glib/gmain.c:3325
    #15 g_main_context_dispatch (context=0x7f7510005000) at ../glib/gmain.c:4043
    #16 0x00007f751a0b32d8 in g_main_context_iterate (context=context@entry=0x7f7510005000, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4119
    #17 0x00007f751a0b338f in g_main_context_iteration (context=0x7f7510005000, may_block=may_block@entry=1) at ../glib/gmain.c:4184
    #18 0x00007f751bc718bf in QEventDispatcherGlib::processEvents (this=0xf81220, flags=...) at kernel/qeventdispatcher_glib.cpp:423
    #19 0x00007f751bc18ceb in QEventLoop::exec (this=this@entry=0x7ffce14c6870, flags=..., flags@entry=...) at ../../include/QtCore/../../src/corelib/global/qflags.h:69
    #20 0x00007f751bc20f60 in QCoreApplication::exec () at ../../include/QtCore/../../src/corelib/global/qflags.h:121
    #21 0x00007f751c1fc35c in QGuiApplication::exec () at kernel/qguiapplication.cpp:1867
    #22 0x00007f751c94d475 in QApplication::exec () at kernel/qapplication.cpp:2824
    #23 0x0000000000415649 in main (argc=<optimized out>, argv=0x7ffce14c69a0) at /home/nate/kde/src/systemsettings/app/main.cpp:222

    Reverting this commit fixes the issue for me.

Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment