Commit 3cec4ed9 authored by Ismael Asensio's avatar Ismael Asensio Committed by Nate Graham
Browse files

Sidebar: Keep headers minimum height on two columns

The implicitHeader binding from sizeHelper is getting overriden
by Kirigami.AbstractApplicationHeader (line 76), which recalculates
a preferred height using the header's childrens implicit heights.

What's really keeping the header height at the desired value are the
back and hamburger buttons, so let's keep that size also when showing
two columns

BUG: 448889
FIXED-IN: 5.24
parent ea764ec5
Pipeline #127403 passed with stage
in 1 minute
......@@ -80,7 +80,7 @@ Kirigami.ScrollablePage {
Layout.fillWidth: true
Layout.fillHeight: true
// Don't be too short when the back and burger buttons aren't visible
Layout.minimumHeight: backButton.implicitHeight
Layout.minimumHeight: Math.max(backButton.implicitHeight, burgerButton.implicitHeight)
Layout.leftMargin: backIcon.visible ? 0 : Kirigami.Units.smallSpacing
level: 3
text: subCategoryColumn.title
......@@ -89,6 +89,7 @@ Kirigami.ScrollablePage {
}
HamburgerMenuButton {
id: burgerButton
visible: !applicationWindow().wideScreen
Keys.onBacktabPressed: {
root.focusPreviousRequest()
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment