Commit 8c865d19 authored by Nate Graham's avatar Nate Graham
Browse files

Sidebar: Add workaround for horizontal scrollbar bug

https://bugreports.qt.io/browse/QTBUG-83890 is still not fixed.

BUG: 458386
FIXED-IN: 5.26
parent 7e3cec9d
Pipeline #225124 passed with stage
in 1 minute and 10 seconds
......@@ -144,6 +144,7 @@ ModuleView::ModuleView(QWidget *parent)
rootLayout->setSpacing(0);
// Configure a layout first
d->mLayout = new QVBoxLayout();
d->mLayout->setSpacing(250);
// Create the Page Widget
d->mPageWidget = new KPageWidget(this);
d->mCustomHeader = new CustomTitle(this);
......@@ -157,7 +158,7 @@ ModuleView::ModuleView(QWidget *parent)
// Zero out only the horizontal spacing (the vertical spacing is fine)
QGridLayout *gridLayout = static_cast<QGridLayout *>(d->mPageWidget->layout());
gridLayout->setHorizontalSpacing(0);
gridLayout->setHorizontalSpacing(80);
d->mLayout->addWidget(d->mPageWidget);
// Create the dialog
......
......@@ -18,6 +18,9 @@ Kirigami.ScrollablePage {
Kirigami.Theme.colorSet: Kirigami.Theme.View
Kirigami.Theme.inherit: false
// HACK: workaround for https://bugreports.qt.io/browse/QTBUG-83890
QQC2.ScrollBar.horizontal.policy: QQC2.ScrollBar.AlwaysOff
header: Kirigami.AbstractApplicationHeader {
id: pageHeader
......
......@@ -18,6 +18,9 @@ Kirigami.ScrollablePage {
Kirigami.Theme.colorSet: Kirigami.Theme.View
Kirigami.Theme.inherit: false
// HACK: workaround for https://bugreports.qt.io/browse/QTBUG-83890
QQC2.ScrollBar.horizontal.policy: QQC2.ScrollBar.AlwaysOff
header: Kirigami.AbstractApplicationHeader {
id: pageHeader
......
  • Hmm this makes my systemsettings crash :(

    file:///usr/share/kpackage/genericqml/org.kde.systemsettings.sidebar/contents/ui/CategoriesPage.qml:22:20: Cannot set properties on horizontal as it is null 
             QQC2.ScrollBar.horizontal.policy: QQC2.ScrollBar.AlwaysOff 
                            ^
    "file:///usr/share/kpackage/genericqml/org.kde.systemsettings.sidebar/contents/ui/CategoriesPage.qml:22:20: Cannot set properties on horizontal as it is null"
    Fatal error while loading the sidebar view qml component
  • Oh no, can reproduce. Looks like unrelated changes snuck in too. Reverting.

  • mentioned in commit e6e1b5ed

    Toggle commit list
  • There is a property int horizontalScrollBarPolicy: QQC2.ScrollBar.AlwaysOff in Kirigami.ScrollablePage component, btw.

  • Indeed, but it's already set to AlwaysOff by default.

Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment