Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Plasma
System Settings
Commits
9daf327a
Commit
9daf327a
authored
Sep 28, 2020
by
David Edmundson
Committed by
Nate Graham
Sep 28, 2020
Browse files
[Sidebar] Avoid reloading already loaded module
BUG: 420196
parent
14f9c104
Changes
1
Hide whitespace changes
Inline
Side-by-side
sidebar/SidebarMode.cpp
View file @
9daf327a
...
...
@@ -436,18 +436,23 @@ void SidebarMode::loadModule( const QModelIndex& activeModule, const QStringList
return
;
}
if
(
!
d
->
moduleView
->
resolveChanges
()
)
{
MenuItem
*
mi
=
activeModule
.
data
(
MenuModel
::
MenuItemRole
).
value
<
MenuItem
*>
();
if
(
!
mi
)
{
return
;
}
d
->
moduleView
->
closeModules
();
MenuItem
*
mi
=
activeModule
.
data
(
MenuModel
::
MenuItemRole
).
value
<
MenuItem
*>
();
// If we are trying to load a module already open
if
(
d
->
moduleView
->
activeModule
()
&&
mi
->
item
()
==
*
d
->
moduleView
->
activeModule
())
{
return
;
}
if
(
!
mi
)
{
if
(
!
d
->
moduleView
->
resolveChanges
()
)
{
return
;
}
d
->
moduleView
->
closeModules
();
if
(
homeItem
())
{
d
->
m_introPageVisible
=
activeModule
==
d
->
categorizedModel
->
mapFromSource
(
d
->
model
->
indexForItem
(
homeItem
()));
emit
introPageVisibleChanged
();
...
...
David Edmundson
@davidedmundson
mentioned in commit
d923aeec
·
Sep 28, 2020
mentioned in commit
d923aeec
mentioned in commit d923aeec835d6a9c195846a00e16566de0af901c
Toggle commit list
David Edmundson
@davidedmundson
mentioned in commit
9604489e
·
Nov 24, 2020
mentioned in commit
9604489e
mentioned in commit 9604489e7f9d3b69a78f7bc5ccdd040e37de9eaa
Toggle commit list
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment