Commit b579a5d9 authored by Nate Graham's avatar Nate Graham
Browse files

Don't let back arrow be re-colored to monochrome

The back button uses a custom content item with the icon being provided
by Kirigami.Icon. Unfortunately, Kirigami.Icon currently suffers from an
issue that causes colored icons that end with "-symbolic" to be forced
to monochrome. See https://bugs.kde.org/show_bug.cgi?id=451538.

There is an open merge request to fix that
(frameworks/kirigami!511), but
the fix is in Frameworks, which means it will only get to people who use
rolling release distros or whose packagers backport the fix.

This commit targeted at the Plasma/5.24 branch only is a local
workaround intended to alleviate the situation for LTS distro users who
are less likely to get the frameworks fix, once it's merged. The master
branch doesn't need the workaround since we can hope  that the
Frameworks fix will be merged before Plasma 5.25.

CCBUG: 451538
parent 99908ccb
Pipeline #155733 passed with stage
in 1 minute and 35 seconds
...@@ -57,7 +57,12 @@ Kirigami.ScrollablePage { ...@@ -57,7 +57,12 @@ Kirigami.ScrollablePage {
contentItem: RowLayout { contentItem: RowLayout {
Kirigami.Icon { Kirigami.Icon {
id: backIcon id: backIcon
source: LayoutMirroring.enabled ? "go-previous-symbolic-rtl" : "go-previous-symbolic" // We are not not using the icon versions that end in -symbolic
// or -symbolic-rtl to work around the issue described in
// https://invent.kde.org/frameworks/kirigami/-/merge_requests/511
// TODO: change back once Kirigami stops automatically making
// icons with the -symbolic suffix monochrome
source: LayoutMirroring.enabled ? "go-next" : "go-previous"
Layout.leftMargin: Kirigami.Units.smallSpacing Layout.leftMargin: Kirigami.Units.smallSpacing
Layout.preferredWidth: Kirigami.Units.iconSizes.smallMedium Layout.preferredWidth: Kirigami.Units.iconSizes.smallMedium
Layout.preferredHeight: Kirigami.Units.iconSizes.smallMedium Layout.preferredHeight: Kirigami.Units.iconSizes.smallMedium
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment